Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable] Update cargo to fix breakage on macOS High Sierra; Update version to 1.22.1. #46183

Merged
merged 2 commits into from
Nov 23, 2017

Conversation

kennytm
Copy link
Member

@kennytm kennytm commented Nov 22, 2017

This backport includes rust-lang/cargo#4739, required for building projects in debug mode with Cargo on macOS High Sierra (see the Cargo PR for details).

This backport includes rust-lang/cargo#4739, required for building projects
in debug mode with cargo on macOS High Sierra.
@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 22, 2017
@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

Unfortunately we have no easy means of producing another stable build , we can do so manually but I will likely be out sick at least this morning and maybe all day :(

@kennytm kennytm changed the title [stable] Update cargo to breakage on macOS High Sierra. [stable] Update cargo for breakage on macOS High Sierra. Nov 22, 2017
@kennytm
Copy link
Member Author

kennytm commented Nov 22, 2017

@alexcrichton Sorry to hear that. Is it possible to hold off the release for macOS until Cargo is patched? (Linux and Windows are not affected.)

(I also wonder why no one reported it during beta, I also don't recall encountering this when using beta.)

@kennytm kennytm changed the title [stable] Update cargo for breakage on macOS High Sierra. [stable] Update cargo to fix breakage on macOS High Sierra; Update version to 1.22.1. Nov 22, 2017
@aturon
Copy link
Member

aturon commented Nov 22, 2017

@bors: r+ p=100 point release

@bors
Copy link
Contributor

bors commented Nov 22, 2017

📌 Commit a9749ef has been approved by aturon

@bors
Copy link
Contributor

bors commented Nov 22, 2017

⌛ Testing commit a9749ef with merge bb408b5...

bors added a commit that referenced this pull request Nov 22, 2017
[stable] Update cargo to fix breakage on macOS High Sierra; Update version to 1.22.1.

This backport includes rust-lang/cargo#4739, required for building projects in debug mode with Cargo on macOS High Sierra (see the Cargo PR for details).
@bors
Copy link
Contributor

bors commented Nov 22, 2017

💔 Test failed - status-appveyor

@kennytm
Copy link
Member Author

kennytm commented Nov 22, 2017

@bors retry #43402

Not now!!

@bors
Copy link
Contributor

bors commented Nov 22, 2017

⌛ Testing commit a9749ef with merge 05e2e1c...

bors added a commit that referenced this pull request Nov 22, 2017
[stable] Update cargo to fix breakage on macOS High Sierra; Update version to 1.22.1.

This backport includes rust-lang/cargo#4739, required for building projects in debug mode with Cargo on macOS High Sierra (see the Cargo PR for details).
@kennytm
Copy link
Member Author

kennytm commented Nov 22, 2017

(The fix of the spurious error, #45170, was merged after 1.22.0 is branched off as beta, thus this spurious error can still happen)

@bors
Copy link
Contributor

bors commented Nov 23, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: aturon
Pushing 05e2e1c to stable...

@bors bors merged commit a9749ef into rust-lang:stable Nov 23, 2017
@kennytm kennytm deleted the backport-cargo-4739 branch November 23, 2017 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants