Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Less globals #46193

Closed
wants to merge 26 commits into from
Closed

WIP: Less globals #46193

wants to merge 26 commits into from

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Nov 22, 2017

This is based on #45912.

r? @arielb1

@kennytm kennytm added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 22, 2017
@Zoxc Zoxc force-pushed the less-globals branch 3 times, most recently from 4652777 to f922075 Compare November 23, 2017 20:15
@bors
Copy link
Contributor

bors commented Nov 24, 2017

☔ The latest upstream changes (presumably #46093) made this pull request unmergeable. Please resolve the merge conflicts.

@Zoxc
Copy link
Contributor Author

Zoxc commented Nov 25, 2017

@bors try

@bors
Copy link
Contributor

bors commented Nov 25, 2017

⌛ Trying commit 057c727 with merge 2581e0d...

bors added a commit that referenced this pull request Nov 25, 2017
@bors
Auto merge of #46193 - Zoxc:less-globals, r=<try>
2581e0d 
WIP: Less globals

This is based on #45912.

r? @arielb1
@bors
Copy link
Contributor

bors commented Nov 25, 2017

☀️ Test successful - status-travis
State: approved= try=True

@Zoxc
Copy link
Contributor Author

Zoxc commented Nov 27, 2017

@Mark-Simulacrum Can I get a perf run?

@Mark-Simulacrum
Copy link
Member

Not currently. Perf is down while we transition to the new collector/frontend, but that should be a relatively temporary event. Once it's back up and running, sure -- it'll be a day or so, and then please ping me again if I haven't posted anything.

@kennytm
Copy link
Member

kennytm commented Nov 29, 2017

Ping @Mark-Simulacrum ↑

@Mark-Simulacrum
Copy link
Member

Please rebase onto master to pick up #46354. Once that's in, I think this should work.

@Zoxc
Copy link
Contributor Author

Zoxc commented Nov 29, 2017

@bors try

bors added a commit that referenced this pull request Nov 29, 2017
@bors
Auto merge of #46193 - Zoxc:less-globals, r=<try>
04c8514 
WIP: Less globals

This is based on #45912.

r? @arielb1
@bors
Copy link
Contributor

bors commented Nov 29, 2017

☀️ Test successful - status-travis
State: approved= try=True

@Mark-Simulacrum
Copy link
Member

Build queued. Should be available on perf.rlo at http://perf.rust-lang.org/compare.html?start=0a2e9ade83ff253bb489c63a95b1f499c5e0916f&end=04c8514ef729c50d18533b9b435fb0659afd07da&stat=instructions%3Au in at most 4 hours, likely less.

@Zoxc Zoxc force-pushed the less-globals branch 2 times, most recently from 32827d4 to bc95965 Compare December 1, 2017 22:49
@Zoxc
Copy link
Contributor Author

Zoxc commented Dec 2, 2017

@bors try

@bors
Copy link
Contributor

bors commented Dec 2, 2017

⌛ Trying commit bc95965 with merge c4c91a0...

bors added a commit that referenced this pull request Dec 2, 2017
@bors
Auto merge of #46193 - Zoxc:less-globals, r=<try>
c4c91a0 
WIP: Less globals

This is based on #45912.

r? @arielb1
@bors
Copy link
Contributor

bors commented Dec 2, 2017

☀️ Test successful - status-travis
State: approved= try=True

@Zoxc
Copy link
Contributor Author

Zoxc commented Dec 2, 2017

@Mark-Simulacrum Let's run perf again, now with thread-safe types :)

@Mark-Simulacrum
Copy link
Member

Perf queued.

@Zoxc
Copy link
Contributor Author

Zoxc commented Dec 2, 2017

Here are the result:
http://perf.rust-lang.org/compare.html?start=bb42071f63830a984c4983f6fbdf982916857f72&end=c4c91a005d72225d7d849276369e39b5b66a4c91&stat=wall-time
The 30% overhead which I got last time seems to have disappeared.

@aidanhs
Copy link
Member

aidanhs commented Dec 7, 2017

@Zoxc just checking in for triage and wondering where this is up to? I can see there are merge conflicts, but once those are resolved is this ready for review?

Zoxc added 21 commits December 10, 2017 16:19
@Zoxc
Make err_count thread safe
e266fbf
@Zoxc
Refactor code so the call to codemap.files() does not deadlock
359f890
@Zoxc
Convert IGNORED_ATTR_NAMES into a global variable and initialize it o…
ca2e0e2 
…n use
@Zoxc
Add a -Z query_threads compiler option
35e2afc
@Zoxc
Assert that GlobalCtxt is Sync
991262b
@Zoxc
Make PROFQ_CHAN a global
dafdbe6
@Zoxc
Make IndexVec implement Send and Sync
fb6631a
@Zoxc
Make TransitiveRelation thread safe. Avoid locking by using get_mut i…
e6d2320 
…n some cases.
@Zoxc
Remove useless Rc
bdf5391
@Zoxc
Use rustc_erase_owner! which produces a Send + Sync erased owner if c…
d1d1c72 
…fg!(parallel_queries)
@Zoxc
Add Encodable and Decodable impls for Arc<[T]>
7427bfa
@Zoxc
Make USED_ATTRS and KNOWN_ATTRS into globals
b626fc4
@Zoxc
Make REGISTERED_DIAGNOSTICS a global
d64651f
@Zoxc
FIXME note + thread safety
b81bd03
@Zoxc
Make HYGIENE_DATA a global
60bf355
@Zoxc
Make Span and Symbol implement Send and Sync
f3cf981
@Zoxc
Make InternedString Send
a87758f
@Zoxc
Make syntax_pos interners globals
29af473
@Zoxc
Mechanical translation which results in GlobalCtxt being Sync
aee48c3
@Zoxc
Remove IGNORED_ATTR_NAMES and make PROFQ_CHAN a scoped thread local.
844c812
@Zoxc
Remove syntax and syntax_pos thread locals
a46f81e
bors added a commit that referenced this pull request Dec 10, 2017
@bors
Auto merge of #46564 - Zoxc:rayon-queries, r=<try>
8ad7c34 
WIP: Parallelize passes using rayon

This builds on #46193 and #45912 and actually makes code run in parallel. This is not quite ready yet since `rustc` is not yet completely thread safe. It also uses a rough fork of rayon which uses fibers/stackful coroutines.
@bors
Copy link
Contributor

bors commented Dec 12, 2017

☔ The latest upstream changes (presumably #46657) made this pull request unmergeable. Please resolve the merge conflicts.

@Zoxc
Copy link
Contributor Author

Zoxc commented Dec 17, 2017

This is being split into smaller PRs.

@Zoxc Zoxc closed this Dec 17, 2017
bors added a commit that referenced this pull request Feb 9, 2018
@bors
Auto merge of #46564 - Zoxc:rayon-queries, r=<try>
3a6dd8c 
WIP: Parallelize passes using rayon

This builds on #46193 and #45912 and actually makes code run in parallel. This is not quite ready yet since `rustc` is not yet completely thread safe. It also uses a rough fork of rayon which uses fibers/stackful coroutines.
@nikomatsakis nikomatsakis mentioned this pull request Apr 6, 2018
Open
31 tasks
bors added a commit that referenced this pull request Apr 19, 2018
@bors
Auto merge of #46564 - Zoxc:rayon-queries, r=<try>
7b0006d 
WIP: Parallelize passes using rayon

This builds on #46193 and #45912 and actually makes code run in parallel. This is not quite ready yet since `rustc` is not yet completely thread safe. It also uses a rough fork of rayon which uses fibers/stackful coroutines.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@arielb1 arielb1

Labels
S-blocked Status: Blocked on something else such as an RFC or other implementation work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Zoxc @bors @Mark-Simulacrum @kennytm @aidanhs @arielb1