Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix treatment of local types in "remote coherence" mode" #46329

Merged
merged 1 commit into from
Nov 28, 2017

Conversation

arielb1
Copy link
Contributor

@arielb1 arielb1 commented Nov 28, 2017

That commit had accidentally snuck in into #44884 and it causes regressions. Revert it.

This reverts commit c48650e.

@bors p=10 - fixes breakage in nightly
r? @eddyb

That commit had accidentally snuck in into rust-lang#44884. Revert it.

This reverts commit c48650e.
@eddyb
Copy link
Member

eddyb commented Nov 28, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Nov 28, 2017

📌 Commit bef4fe9 has been approved by eddyb

@arielb1
Copy link
Contributor Author

arielb1 commented Nov 28, 2017

@bors p=10

@kennytm
Copy link
Member

kennytm commented Nov 28, 2017

Is this a fix for #46328?

@kennytm kennytm added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 28, 2017
@bors
Copy link
Contributor

bors commented Nov 28, 2017

⌛ Testing commit bef4fe9 with merge 5a59704...

bors added a commit that referenced this pull request Nov 28, 2017
Revert "fix treatment of local types in "remote coherence" mode"

That commit had accidentally snuck in into #44884 and it causes regressions. Revert it.

This reverts commit c48650e.

@bors p=10 - fixes breakage in nightly
r? @eddyb
@bors
Copy link
Contributor

bors commented Nov 28, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing 5a59704 to master...

@bors bors merged commit bef4fe9 into rust-lang:master Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants