Record all imports (use, extern crate) in the crate metadata
#46419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kennytm
added
the
S-waiting-on-author
jseyfried
force-pushed
the
all_imports_in_metadata
branch
4 times, most recently
from
3478b62 to
2677909
Compare
jseyfried
added
S-waiting-on-review
jseyfried
force-pushed
the
all_imports_in_metadata
branch
from
2677909 to
e99c602
Compare
jseyfried
force-pushed
the
all_imports_in_metadata
branch
from
e99c602 to
1b9d058
Compare
|
This is ready for review. |
|
Review ping for you @nrc ! |
|
@bors: r+ |
|
📌 Commit 1b9d058 has been approved by |
bors
added a commit
that referenced
this pull request
Dec 13, 2017
Record all imports (`use`, `extern crate`) in the crate metadata This PR adds non-`pub` `use` and `extern crate` imports in the crate metadata since hygienic macros invoked in other crates may use them. We already include all other non-`pub` items in the crate metadata. This improves import suggestions in some cases. Fixes #42337. r? @nrc
kennytm
added
S-waiting-on-bors
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds non-
pubuseandextern crateimports in the crate metadata since hygienic macros invoked in other crates may use them. We already include all other non-pubitems in the crate metadata. This improves import suggestions in some cases.Fixes #42337.
r? @nrc