Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention the name of ? in Result's docs #46431

Merged
merged 1 commit into from
Dec 6, 2017
Merged

Conversation

steveklabnik
Copy link
Member

Fixes #42725

or at least, this is the best we can really do. #35946 is tracking
better errors already, so that should cover the other part of it.

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 1, 2017
@kennytm
Copy link
Member

kennytm commented Dec 1, 2017

Random assignment from docs team — r? @QuietMisdreavus

//! syntax hides some of the boilerplate of propagating errors up the
//! call stack.
//! [`Result`] type, the error handling can be tedious. The question mark
//! operator, [`?`], syntax hides some of the boilerplate of propagating errors
Copy link
Member

@QuietMisdreavus QuietMisdreavus Dec 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The question mark operator, ?, syntax hides some...

Seems like it would read better without "syntax" there.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated!

@cuviper
Copy link
Member

cuviper commented Dec 1, 2017

Is "question mark operator" really the official term now? I much prefer "try operator".
(Just like we wouldn't call ^ the "caret operator", etc.)

@QuietMisdreavus
Copy link
Member

The reference currently expands it to "question mark" operator, at least.

Fixes rust-lang#42725

or at least, this is the best we can really do. rust-lang#35946 is tracking
better errors already, so that should cover the other part of it.
@QuietMisdreavus
Copy link
Member

@bors r+ rollup

Thanks! Any farther discussion of what to call the ? operator can happen on the reference, and can spread out from there.

@bors
Copy link
Contributor

bors commented Dec 5, 2017

📌 Commit 893474e has been approved by QuietMisdreavus

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 5, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Dec 6, 2017
…avus

Mention the name of ? in Result's docs

Fixes rust-lang#42725

or at least, this is the best we can really do. rust-lang#35946 is tracking
better errors already, so that should cover the other part of it.
bors added a commit that referenced this pull request Dec 6, 2017
Rollup of 7 pull requests

- Successful merges: #46136, #46378, #46431, #46483, #46495, #46502, #46512
- Failed merges:
@bors bors merged commit 893474e into rust-lang:master Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants