Resolve absolute paths as extern under a feature flag #46613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrochenkov
commented
Dec 10, 2017
| let ImportDirective { ref module_path, span, .. } = *directive; | ||
|
|
||
| // Extern crate mode for absolute paths needs some | ||
| // special support for single-segment imports. |
There was a problem hiding this comment.
The part about single-segment imports (use my_crate;/use crate;) works, but it is kinda hacked into.
Solving it properly requires larger refactoring that would also solve a number of pre-existing problems (#29036 and similar).
kennytm
added
the
S-waiting-on-review
nikomatsakis
approved these changes
Dec 11, 2017
| @@ -2959,6 +2960,16 @@ impl<'a> Resolver<'a> { | |||
| // `$crate::a::b` | |||
| module = Some(self.resolve_crate_root(ident.node.ctxt)); | |||
| continue | |||
| } else if i == 1 && self.session.features.borrow().extern_absolute_paths && | |||
| path[0].node.name == keywords::CrateRoot.name() && | |||
There was a problem hiding this comment.
Nit: isn't there some helper function we can use here for this test against keywords::CrateRoot.name()?
There was a problem hiding this comment.
There's no such existing function.
(Also there are too many "crate roots" with different properties now, it's better to be explicit.)
| // Extern crate mode for absolute paths needs some | ||
| // special support for single-segment imports. | ||
| let extern_absolute_paths = self.session.features.borrow().extern_absolute_paths; | ||
| if module_path.len() == 1 && module_path[0].node.name == keywords::CrateRoot.name() { |
There was a problem hiding this comment.
Nit: as above, helper function?
|
@bors r+ |
|
📌 Commit 675581a has been approved by |
kennytm
added
S-waiting-on-bors
|
⌛ Testing commit 675581a290571ea38141b1f6e202bf66d444122a with merge 4ae1d40e143c9a1a3722d1b921255c4b4e2bdc74... |
|
💔 Test failed - status-travis |
|
The new gate test failed on |
kennytm
added
S-waiting-on-author
kennytm
reviewed
Dec 12, 2017
src/libsyntax/feature_gate.rs
Outdated
| @@ -430,6 +430,9 @@ declare_features! ( | |||
|
|
|||
| // generic associated types (RFC 1598) | |||
| (active, generic_associated_types, "1.23.0", Some(44265)), | |||
|
|
|||
| // Resolve absolute paths as paths from other crates | |||
| (active, extern_absolute_paths, "1.23.0", Some(44660)), | |||
| // option. This file may not be copied, modified, or distributed | ||
| // except according to those terms. | ||
|
|
||
| fn main() {} |
|
@bors r=nikomatsakis |
|
📌 Commit b07e26e has been approved by |
kennytm
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Dec 13, 2017
Resolve absolute paths as extern under a feature flag cc #44660 r? @nikomatsakis
|
☀️ Test successful - status-appveyor, status-travis |
bors
added a commit
that referenced
this pull request
Jan 7, 2018
Support `extern` in paths Implement the primary alternative to #46613 + #45771, achieving the same effect without requiring changes to other imports. Both need to be experimentally evaluated before making further progress. The PR also adds docs for all these related features into the unstable book. cc #44660 r? @nikomatsakis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #44660
r? @nikomatsakis