Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily use the old Travis image. #46694

Merged
merged 1 commit into from
Dec 12, 2017

Conversation

kennytm
Copy link
Member

@kennytm kennytm commented Dec 12, 2017

@aidanhs
Copy link
Member

aidanhs commented Dec 12, 2017

Ref https://blog.travis-ci.com/2017-12-12-new-trusty-images-q4-launch

@bors r+ p=100

(@kennytm can you do the treeclosed/treeopen incantations?)

Edit: ah I see, treeclosed applies to any PR below a certain priority so no need to open tree straight away

@bors
Copy link
Contributor

bors commented Dec 12, 2017

📌 Commit c0c26a6 has been approved by aidanhs

@kennytm
Copy link
Member Author

kennytm commented Dec 12, 2017

Actually I prefer to roll this up with #46692 😊. Creating a rollup.

kennytm added a commit to kennytm/rust that referenced this pull request Dec 12, 2017
@bors
Copy link
Contributor

bors commented Dec 12, 2017

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Dec 12, 2017

📌 Commit c0c26a6 has been approved by aidanhs

bors added a commit that referenced this pull request Dec 12, 2017
Rollup of 4 pull requests

- Successful merges: #46668, #46672, #46691, #46694
- Failed merges:
@kennytm
Copy link
Member Author

kennytm commented Dec 12, 2017

@aidanhs I would still explicitly reopen the tree as I'm not sure if the r+ would be affected by servo/homu#139. The purpose of me closing the tree is just to avoid having to retry dozens of PRs as cleanup 😄

@kennytm kennytm added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 12, 2017
@bors
Copy link
Contributor

bors commented Dec 12, 2017

⌛ Testing commit c0c26a6 with merge 6a36019...

@bors bors merged commit c0c26a6 into rust-lang:master Dec 12, 2017
@kennytm kennytm deleted the temporarily-use-old-travis-image branch December 13, 2017 05:27
bors added a commit that referenced this pull request Dec 25, 2017
Revert #46694 (Temporarily use the old Travis image)

This PR reverts #46694, and applies the solution recommended in travis-ci/travis-ci#8891 (comment).

r? @aidanhs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants