-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closure type error ui tweak #46864
Merged
Merged
Closure type error ui tweak #46864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not point at the same span on all notes/help messages, and instead show them without a span.
(rust_highfive has picked a reviewer for you, use r? to override) |
r=me but travis is unhappy |
kennytm
added
the
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Dec 20, 2017
estebank
force-pushed
the
closure-type-err-sp
branch
from
December 20, 2017 17:50
0f99320
to
bb92bb4
Compare
estebank
force-pushed
the
closure-type-err-sp
branch
from
December 20, 2017 19:03
bb92bb4
to
eed98d5
Compare
@bors r+ |
📌 Commit eed98d5 has been approved by |
kennytm
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Dec 20, 2017
bors
added a commit
that referenced
this pull request
Dec 23, 2017
Closure type error ui tweak Do not point at the same span on all notes/help messages, and instead show them without a span.
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not point at the same span on all notes/help messages, and instead
show them without a span.