Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closure type error ui tweak #46864

Merged
merged 3 commits into from
Dec 23, 2017
Merged

Conversation

estebank
Copy link
Contributor

Do not point at the same span on all notes/help messages, and instead
show them without a span.

Do not point at the same span on all notes/help messages, and instead
show them without a span.
@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@nikomatsakis
Copy link
Contributor

r=me but travis is unhappy

@kennytm kennytm added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Dec 20, 2017
@estebank estebank force-pushed the closure-type-err-sp branch from 0f99320 to bb92bb4 Compare December 20, 2017 17:50
@estebank estebank force-pushed the closure-type-err-sp branch from bb92bb4 to eed98d5 Compare December 20, 2017 19:03
@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Dec 20, 2017

📌 Commit eed98d5 has been approved by nikomatsakis

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 20, 2017
@bors
Copy link
Contributor

bors commented Dec 23, 2017

⌛ Testing commit eed98d5 with merge 1699293...

bors added a commit that referenced this pull request Dec 23, 2017
Closure type error ui tweak

Do not point at the same span on all notes/help messages, and instead
show them without a span.
@bors
Copy link
Contributor

bors commented Dec 23, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 1699293 to master...

@bors bors merged commit eed98d5 into rust-lang:master Dec 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants