Generate code for unused const- and inline-fns if -Clink-dead-code is specified. #46916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors: r+ Nice! |
|
📌 Commit f284ebb has been approved by |
arielb1
added
the
beta-nominated
kennytm
added
the
S-waiting-on-bors
|
@bors r- The new test failed in the rollup. |
kennytm
requested changes
Dec 21, 2017
src/test/codegen/link-dead-code.rs
Outdated
| // code for functions that would otherwise be skipped. | ||
|
|
||
| // CHECK-LABEL: define hidden i64 @_ZN14link_dead_code8const_fn | ||
| const fn const_fn() -> usize { 1 } |
There was a problem hiding this comment.
Please change the usize to some more portable type. This test is failing on 32-bit platforms.
[00:52:46] ---- [codegen] codegen/link-dead-code.rs stdout ----
[00:52:46]
[00:52:46] error: verification with 'FileCheck' failed
[00:52:46] status: exit code: 1
[00:52:46] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin/FileCheck" "--input-file" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/link-dead-code.ll" "/checkout/src/test/codegen/link-dead-code.rs"
[00:52:46] stdout:
[00:52:46] ------------------------------------------
[00:52:46]
[00:52:46] ------------------------------------------
[00:52:46] stderr:
[00:52:46] ------------------------------------------
[00:52:46] /checkout/src/test/codegen/link-dead-code.rs:19:17: error: expected string not found in input
[00:52:46] // CHECK-LABEL: define hidden i64 @_ZN14link_dead_code8const_fn
[00:52:46] ^
[00:52:46] /checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/link-dead-code.ll:1:1: note: scanning from here
[00:52:46] ; ModuleID = 'link_dead_code0-8787f43e282added376259c1adb08b80.rs'
[00:52:46] ^
[00:52:46] /checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/link-dead-code.ll:8:1: note: possible intended match here
[00:52:46] define hidden i32 @_ZN14link_dead_code8const_fn17h307759a84b38b8b4E() unnamed_addr #0 {
[00:52:46] ^
[00:52:46]
[00:52:46] ------------------------------------------
[00:52:46]
[00:52:46] thread '[codegen] codegen/link-dead-code.rs' panicked at 'explicit panic', /checkout/src/tools/compiletest/src/runtest.rs:2776:8
[00:52:46] note: Run with `RUST_BACKTRACE=1` for a backtrace.
|
@michaelwoerister are you going to be able to address the problem pointed out by kennytm? Times getting very tight to backport this into beta... |
|
Whoops, sorry, didn't see this because of PTO. |
michaelwoerister
force-pushed
the
generate-dead-code-plz
branch
from
f284ebb to
238ed47
Compare
kennytm
approved these changes
Jan 4, 2018
|
@bors r=alexcrichton |
|
📌 Commit 238ed47 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 4, 2018
…xcrichton Generate code for unused const- and inline-fns if -Clink-dead-code is specified. Fixes #46467. r? @alexcrichton
|
☀️ Test successful - status-appveyor, status-travis |
nagisa
added
the
T-compiler
alexcrichton
added
the
beta-accepted
|
Accepting for backport as it fixes a regression #46467 |
Merged
alexcrichton
removed
the
beta-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46467.
r? @alexcrichton