Make normalize_and_test_predicates into a query #47200
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
That seems good, actually. |
|
@bors r+ |
|
📌 Commit 766465f has been approved by |
shepmaster
added
the
S-waiting-on-bors
Make normalize_and_test_predicates into a query From #44891. I'm not real solid on how `dep_graph` stuff works, but if a node is going to have a key (again, not sure how important that is), then the key needs to be `Copy`. So since `normalize_and_test_predicates` only had one out-of-module use, I changed that call site to use a new function, `substitute_normalize_and_test_predicates` which is the query and enables having the arguments be `Copy`. Hopefully this makes sense. r? @nikomatsakis and/or @michaelwoerister
|
☀️ Test successful - status-appveyor, status-travis |
From #44891.
I'm not real solid on how
dep_graphstuff works, but if a node is going to have a key (again, not sure how important that is), then the key needs to beCopy. So sincenormalize_and_test_predicatesonly had one out-of-module use, I changed that call site to use a new function,substitute_normalize_and_test_predicateswhich is the query and enables having the arguments beCopy. Hopefully this makes sense.r? @nikomatsakis
and/or @michaelwoerister