Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest casting on numeric type error #47247

Merged
merged 6 commits into from
Jan 22, 2018
Merged

Suggest casting on numeric type error #47247

merged 6 commits into from
Jan 22, 2018

Commits on Jan 15, 2018

  1. Suggest casting on numeric type error

    @estebank
    estebank committed Jan 15, 2018
    Configuration menu
    Copy the full SHA
    aec1623 View commit details
    Browse the repository at this point in the history

  2. Use into for casting when possible

    @estebank
    estebank committed Jan 15, 2018
    Configuration menu
    Copy the full SHA
    af91d99 View commit details
    Browse the repository at this point in the history

  3. Only suggest casting numeric types using into()

    @estebank
    estebank committed Jan 15, 2018
    Configuration menu
    Copy the full SHA
    509ea8e View commit details
    Browse the repository at this point in the history

  4. Use s::u::p::expr_precedence and fix message 

     - Use `syntax::util::parser::expr_precedence` to determine wether
   parenthesis are needed around the casting target.
 - Update message to not incorrectly mention rounding on `.into()`
   suggestions, as those types that do have that implemented will never
   round.
    @estebank
    estebank committed Jan 15, 2018
    Configuration menu
    Copy the full SHA
    09efaaf View commit details
    Browse the repository at this point in the history

  5. Use single source of truth for expr precedence 

    Introduce a new unified type that holds the expression precedence for
both AST and HIR nodes.
    @estebank
    estebank committed Jan 15, 2018
    Configuration menu
    Copy the full SHA
    afe8d13 View commit details
    Browse the repository at this point in the history

  6. Move ExprPrecedence to libsyntax/util/parser.rs

    @estebank
    estebank committed Jan 15, 2018
    Configuration menu
    Copy the full SHA
    71c0873 View commit details
    Browse the repository at this point in the history