Assignment to immutable argument: diagnostic tweak #47261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
estebank
force-pushed
the
immutable-arg
branch
from
4a01467
to
1890818
Compare
estebank
added
the
S-waiting-on-review
petrochenkov
reviewed
Jan 9, 2018
| 14 | _x = 4; | ||
| | ^^^^^^ cannot assign twice to immutable variable | ||
|
|
||
| error[E0384]: cannot assign twice to immutable variable `_x` (Mir) |
There was a problem hiding this comment.
Shouldn't this message say "argument" instead of "variable" as well?
petrochenkov
added
S-waiting-on-author
estebank
added
S-waiting-on-review
estebank
force-pushed
the
immutable-arg
branch
from
efd08e0
to
e1ee593
Compare
estebank
force-pushed
the
immutable-arg
branch
from
e1ee593
to
90bc98c
Compare
|
@bors r+ |
|
📌 Commit 90bc98c has been approved by |
| } | ||
| } else { | ||
| false | ||
| }; |
There was a problem hiding this comment.
So
much
vertical
space.
Now every time I see stuff like this I'm rewording it with is expressions in my head.
let is_arg = place is Place::Local(local) && self.mir.local_kind(*local) is LocalKind::Arg;
There was a problem hiding this comment.
@petrochenkov To be fair this is just:
let is_arg = match place {
Place::Local(local) => self.mir.local_kind(*local) == LocalKind::Arg,
_ => false
};I think if let is overused and match is better in many cases.
There was a problem hiding this comment.
True, I usually revert to using match in cases like this. Somehow it escaped me here ^_^
petrochenkov
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jan 14, 2018
Assignment to immutable argument: diagnostic tweak Re #46659.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re #46659.