Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't look for niches inside generator types. Fixes #47253 #47270

Merged
merged 1 commit into from
Jan 9, 2018
Merged

Don't look for niches inside generator types. Fixes #47253 #47270

merged 1 commit into from
Jan 9, 2018

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Jan 8, 2018

r? @eddyb

@eddyb
Copy link
Member

eddyb commented Jan 8, 2018

@bors r+

@bors
Copy link
Contributor

bors commented Jan 8, 2018

📌 Commit 1a7b00d has been approved by eddyb

@eddyb eddyb added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 8, 2018
@Zoxc
Copy link
Contributor Author

Zoxc commented Jan 8, 2018

@eddyb You can't use generators on beta though?

@kennytm kennytm added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 8, 2018
@kennytm kennytm mentioned this pull request Jan 8, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Jan 8, 2018
@kennytm
Rollup merge of rust-lang#47270 - Zoxc:gen-layout-fix, r=eddyb
9dd7cae 
Don't look for niches inside generator types. Fixes rust-lang#47253

r? @eddyb
bors added a commit that referenced this pull request Jan 9, 2018
@bors
Auto merge of #47276 - kennytm:rollup, r=kennytm
74966b5 
Rollup of 10 pull requests

- Successful merges: #47210, #47233, #47246, #47254, #47256, #47258, #47259, #47263, #47270, #47272
- Failed merges: #47248
@bors bors merged commit 1a7b00d into rust-lang:master Jan 9, 2018
@dwrensha dwrensha mentioned this pull request Jan 10, 2018
Open
@alexcrichton
Copy link
Member

@eddyb mind expanding a bit on the beta nomination? With what @Zoxc said we may not wish to beta nominate?

@eddyb
Copy link
Member

eddyb commented Jan 10, 2018

@alexcrichton Sure, assuming no code in the standard library or the compiler uses generators.

@alexcrichton
Copy link
Member

Indeed! Ok removing nomination.

@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Zoxc @eddyb @bors @alexcrichton @kennytm