Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix faulty comment #47302

Merged
merged 1 commit into from
Jan 17, 2018
Merged

fix faulty comment #47302

merged 1 commit into from
Jan 17, 2018

Conversation

andjo403
Copy link
Contributor

@andjo403 andjo403 commented Jan 9, 2018

after #43506 there is no fixed number of request sent.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @michaelwoerister (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@kennytm
Copy link
Member

kennytm commented Jan 10, 2018

Thanks for the PR! We’ll periodically check in on it to make sure that @michaelwoerister or someone else from the team reviews it soon.

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 10, 2018
@michaelwoerister
Copy link
Member

Thanks @andjo403!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 15, 2018

📌 Commit bdc34fd has been approved by michaelwoerister

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 16, 2018
@GuillaumeGomez
Rollup merge of rust-lang#47302 - andjo403:commentfix, r=michaelwoeri…
bca76c1 
…ster

fix faulty comment

after rust-lang#43506 there is no fixed number of request sent.
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jan 16, 2018
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 16, 2018
@GuillaumeGomez
Rollup merge of rust-lang#47302 - andjo403:commentfix, r=michaelwoeri…
9928bf2 
…ster

fix faulty comment

after rust-lang#43506 there is no fixed number of request sent.
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jan 16, 2018
Closed
bors added a commit that referenced this pull request Jan 16, 2018
@bors
Auto merge of #47492 - GuillaumeGomez:rollup, r=GuillaumeGomez
047132d 
Rollup of 6 pull requests

- Successful merges: #47250, #47302, #47387, #47398, #47436, #47444
- Failed merges:
bors added a commit that referenced this pull request Jan 17, 2018
@bors
Auto merge of #47492 - GuillaumeGomez:rollup, r=GuillaumeGomez
2d3558e 
Rollup of 6 pull requests

- Successful merges: #47250, #47302, #47387, #47398, #47436, #47444
- Failed merges:
kennytm added a commit to kennytm/rust that referenced this pull request Jan 17, 2018
@kennytm
Rollup merge of rust-lang#47302 - andjo403:commentfix, r=michaelwoeri…
3dc6f3c 
…ster

fix faulty comment

after rust-lang#43506 there is no fixed number of request sent.
@kennytm kennytm mentioned this pull request Jan 17, 2018
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Jan 17, 2018
@kennytm
Rollup merge of rust-lang#47302 - andjo403:commentfix, r=michaelwoeri…
283ee54 
…ster

fix faulty comment

after rust-lang#43506 there is no fixed number of request sent.
@kennytm kennytm mentioned this pull request Jan 17, 2018
Merged
bors added a commit that referenced this pull request Jan 17, 2018
@bors
Auto merge of #47522 - kennytm:rollup, r=kennytm
0f9c784 
Rollup of 21 pull requests

- Successful merges: #47302, #47333, #47387, #47404, #47407, #47426, #47427, #47436, #47444, #47456, #47458, #47467, #47479, #47481, #47483, #47487, #47497, #47498, #47505, #47509, #47514
- Failed merges:
@bors bors merged commit bdc34fd into rust-lang:master Jan 17, 2018
@andjo403 andjo403 deleted the commentfix branch February 28, 2021 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaelwoerister michaelwoerister

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andjo403 @rust-highfive @kennytm @michaelwoerister @bors