Add NLL tests for #46557 and #38899 #47368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes rust-lang#47366 Adapt the sample code from the issues into mir-borrowck/nll test cases.
|
The mentoring instructions were unclear here. It seems that we want these tests to fail compilation as they both unsoundly passed AST borrowck. |
|
@chrisvittal When you said the instructions were unclear, were you referring to the step that said that the tests should include the comment |
|
That was a mistake on my part. We expect errors! |
nikomatsakis
requested changes
Jan 12, 2018
|
|
||
| // Regression test for issue #38899 | ||
|
|
||
| // compile-flags:-Znll -Zborrowck=mir -Zverbose |
There was a problem hiding this comment.
can we remove the compile-flags? They should not be necessary. feature(nll) should suffice.
nikomatsakis
approved these changes
Jan 12, 2018
|
@bors r+ |
|
📌 Commit e14720b has been approved by |
shepmaster
added
the
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Jan 15, 2018
Add NLL tests for rust-lang#46557 and rust-lang#38899 This adapts the sample code from the two issues into test code. Closes rust-lang#46557 Closes rust-lang#38899 r? @nikomatsakis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adapts the sample code from the two issues into test code.
Closes #46557
Closes #38899
r? @nikomatsakis