-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustc_trans: take into account primitives larger than 8 bytes. #47437
Conversation
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
r? @nagisa |
@bors r+ |
📌 Commit 5934174 has been approved by |
☔ The latest upstream changes (presumably #47209) made this pull request unmergeable. Please resolve the merge conflicts. |
@bors r=nagisa |
📌 Commit cbeebc5 has been approved by |
rustc_trans: take into account primitives larger than 8 bytes. Fixes rust-lang#38763 by marking all "eightbytes" covered by a primitive appropriately, not just the first.
@bors r- This PR failed in the rollup #47748 because Emscripten doesn't support i128. Please apply 68f2e1e: From 68f2e1ebf2e0f959685fbce3f69349b3e21f34cc Mon Sep 17 00:00:00 2001
From: Alex Crichton <alex@alexcrichton.com>
Date: Thu, 25 Jan 2018 21:04:01 -0800
Subject: [PATCH] Ignore an i128 test on emscripten
---
src/test/run-pass/issue-38763.rs | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/test/run-pass/issue-38763.rs b/src/test/run-pass/issue-38763.rs
index 4bf9513d64f9..01cc8265a399 100644
--- a/src/test/run-pass/issue-38763.rs
+++ b/src/test/run-pass/issue-38763.rs
@@ -8,6 +8,8 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.
+// ignore-emscripten
+
#![feature(i128_type)]
#[repr(C)] |
@bors r=nagisa |
📌 Commit 035eee8 has been approved by |
Already merged as part of #47748 😀 |
Fixes #38763 by marking all "eightbytes" covered by a primitive appropriately, not just the first.