Deprecate std::net::lookup_host #47510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
added
T-libs-api
kennytm
reviewed
Jan 17, 2018
src/libstd/net/mod.rs
Outdated
| @@ -134,12 +134,15 @@ fn each_addr<A: ToSocketAddrs, F, T>(addr: A, mut f: F) -> io::Result<T> | |||
| iterator and returning socket \ | |||
| addresses", | |||
| issue = "27705")] | |||
| #[rustc_deprecated(since = "1.26", reason = "Use the ToSocketAddrs trait instead")] | |||
There was a problem hiding this comment.
The current nightly version is still 1.25...?
|
r=me with the typo @kennytm pointed out |
kennytm
added
S-waiting-on-author
We intended to do this quite a while ago but it snuck through.
|
@bors r=alexcrichton |
|
📌 Commit 7457226 has been approved by |
sfackler
force-pushed
the
deprecate-dns
branch
from
7457226 to
908aa38
Compare
|
@bors r=alexcrichton |
|
📌 Commit 908aa38 has been approved by |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jan 19, 2018
Deprecate std::net::lookup_host We intended to do this quite a while ago but it snuck through. r? @alexcrichton
bors
added a commit
that referenced
this pull request
Jan 19, 2018
|
@bors rollup |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jan 20, 2018
Deprecate std::net::lookup_host We intended to do this quite a while ago but it snuck through. r? @alexcrichton
cuviper
added a commit
to cuviper/rust
that referenced
this pull request
May 3, 2018
These are unstable, and were deprecated by rust-lang#47510, since Rust 1.25. The internal `sys` implementations are still kept to support the call in the common `resolve_socket_addr`.
bors
added a commit
that referenced
this pull request
May 4, 2018
Remove the deprecated std::net::{lookup_host,LookupHost}
These are unstable, and were deprecated by #47510, since Rust 1.25. The
internal `sys` implementations are still kept to support the call in the
common `resolve_socket_addr`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We intended to do this quite a while ago but it snuck through.
r? @alexcrichton