Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add regression test for #29723 #47549

Merged
merged 4 commits into from
Jan 23, 2018
Merged

Add regression test for #29723 #47549

merged 4 commits into from
Jan 23, 2018

Conversation

Manishearth
Copy link
Member

@Manishearth Manishearth commented Jan 18, 2018 •
edited by nikomatsakis
Loading

@Manishearth Manishearth mentioned this pull request Jan 18, 2018
Closed
@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 18, 2018
kennytm
kennytm reviewed Jan 18, 2018
View reviewed changes
src/test/ui/issue-29723.rs Outdated
s
}
};
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

[00:04:49] tidy error: /checkout/src/test/ui/issue-29723.rs: missing trailing newline

@Manishearth
Copy link
Member Author

fixed

@nikomatsakis
Copy link
Contributor

missing main function

@nikomatsakis
Copy link
Contributor

r=me once travis is green -- probably just change foo to main, no?

@nikomatsakis
Copy link
Contributor

I did it myself :)

@kennytm
Copy link
Member

kennytm commented Jan 21, 2018

@bors r=nikomatsakis

@bors
Copy link
Contributor

bors commented Jan 21, 2018

📌 Commit 67f922b has been approved by nikomatsakis

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 21, 2018
@frewsxcv
Copy link
Member

@bors rollup

kennytm added a commit to kennytm/rust that referenced this pull request Jan 23, 2018
@kennytm
Rollup merge of rust-lang#47549 - Manishearth:29723-regression, r=nik…
658ccae 
…omatsakis

Add regression test for rust-lang#29723

cc rust-lang#29723

r? @nikomatsakis
@kennytm kennytm mentioned this pull request Jan 23, 2018
Merged
bors added a commit that referenced this pull request Jan 23, 2018
@bors
Auto merge of #47678 - kennytm:rollup, r=kennytm
4e3901d 
Rollup of 14 pull requests

- Successful merges: #47423, #47425, #47440, #47541, #47549, #47554, #47558, #47610, #47635, #47655, #47661, #47662, #47667, #47672
- Failed merges:
@bors bors merged commit 67f922b into rust-lang:master Jan 23, 2018
@matthewjasper matthewjasper mentioned this pull request Apr 24, 2018
Closed
@pnkfelix pnkfelix mentioned this pull request Aug 17, 2021
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm left review comments

Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Manishearth @nikomatsakis @kennytm @bors @frewsxcv