Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ICE with use self; #47633

Merged
merged 1 commit into from
Jan 22, 2018
Merged

Fix ICE with use self; #47633

merged 1 commit into from
Jan 22, 2018

Conversation

pietroalbini
Copy link
Member

Closes #47623

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @michaelwoerister (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@nagisa
Copy link
Member

nagisa commented Jan 21, 2018

@bors r+

@bors
Copy link
Contributor

bors commented Jan 21, 2018

📌 Commit e9d0141 has been approved by nagisa

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 21, 2018
@GuillaumeGomez
Rollup merge of rust-lang#47633 - pietroalbini:fix-ice-use-self, r=na…
05f77ac 
…gisa

Fix ICE with `use self;`

Closes rust-lang#47623
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jan 21, 2018
Merged
bors added a commit that referenced this pull request Jan 21, 2018
@bors
Auto merge of #47644 - GuillaumeGomez:rollup, r=GuillaumeGomez
ff2a7c8 
Rollup of 9 pull requests

- Successful merges: #47247, #47334, #47512, #47582, #47595, #47625, #47632, #47633, #47637
- Failed merges:
@bors bors merged commit e9d0141 into rust-lang:master Jan 22, 2018
@pietroalbini pietroalbini deleted the fix-ice-use-self branch January 24, 2018 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaelwoerister michaelwoerister

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pietroalbini @rust-highfive @nagisa @bors @michaelwoerister