Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused data structures #47835

Merged
merged 2 commits into from
Feb 10, 2018
Merged

Remove unused data structures #47835

merged 2 commits into from
Feb 10, 2018

Conversation

Mark-Simulacrum
Copy link
Member

Cleanup; as far as I can tell the compiler no longer uses these.

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@eddyb
Copy link
Member

eddyb commented Jan 29, 2018

r? @michaelwoerister

@kennytm kennytm added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 29, 2018
@shepmaster
Copy link
Member

image

😻

@shepmaster
Copy link
Member

Ping from triage, @michaelwoerister !

@BatmanAoD
Copy link
Member

Ping from triage, @michaelwoerister (also pinged on IRC). @rust-lang/compiler this PR is now 10 days old; if mw does not respond, can a new reviewer be selected?

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Feb 8, 2018

📌 Commit caa42e1 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 8, 2018
@nikomatsakis
Copy link
Contributor

r? @nikomatsakis

kennytm added a commit to kennytm/rust that referenced this pull request Feb 8, 2018
@kennytm
Rollup merge of rust-lang#47835 - Mark-Simulacrum:remove-data-structs…
445d699 
…, r=nikomatsakis

Remove unused data structures

Cleanup; as far as I can tell the compiler no longer uses these.
@kennytm kennytm mentioned this pull request Feb 8, 2018
Closed
bors added a commit that referenced this pull request Feb 8, 2018
@bors
Auto merge of #48077 - kennytm:rollup, r=kennytm
4b3e620 
Rollup of 7 pull requests

- Successful merges: #47835, #47854, #48015, #48047, #48051, #48058, #48064
- Failed merges:
bors added a commit that referenced this pull request Feb 9, 2018
@bors
Auto merge of #48077 - kennytm:rollup, r=kennytm
b29141d 
Rollup of 7 pull requests

- Successful merges: #47835, #47854, #48015, #48047, #48051, #48058, #48064
- Failed merges:
bors added a commit that referenced this pull request Feb 9, 2018
@bors
Auto merge of #48077 - kennytm:rollup, r=kennytm
68df9d6 
Rollup of 12 pull requests

- Successful merges: #47835, #47854, #48015, #48047, #48051, #48058, #48064, #47790, #48059, #48078, #48080, #48085
- Failed merges:
kennytm added a commit to kennytm/rust that referenced this pull request Feb 9, 2018
@kennytm
Rollup merge of rust-lang#47835 - Mark-Simulacrum:remove-data-structs…
df1c16c 
…, r=nikomatsakis

Remove unused data structures

Cleanup; as far as I can tell the compiler no longer uses these.
@kennytm kennytm mentioned this pull request Feb 9, 2018
Closed
bors added a commit that referenced this pull request Feb 9, 2018
@bors
Auto merge of #48104 - kennytm:rollup, r=kennytm
394ccaf 
Rollup of 17 pull requests

- Successful merges: #47790, #47835, #47854, #48015, #48047, #48051, #48058, #48059, #48064, #48078, #48080, #48085, #48086, #48090, #48093, #48098, #48101
- Failed merges:
kennytm added a commit to kennytm/rust that referenced this pull request Feb 10, 2018
@kennytm
Rollup merge of rust-lang#47835 - Mark-Simulacrum:remove-data-structs…
4f8ea49 
…, r=nikomatsakis

Remove unused data structures

Cleanup; as far as I can tell the compiler no longer uses these.
@kennytm kennytm mentioned this pull request Feb 10, 2018
Merged
bors added a commit that referenced this pull request Feb 10, 2018
@bors
Auto merge of #48113 - kennytm:rollup, r=kennytm
d5e3164 
Rollup of 16 pull requests

- Successful merges: #47790, #47835, #47854, #48015, #48047, #48051, #48058, #48059, #48064, #48078, #48080, #48086, #48098, #48101, #48107, #48100
- Failed merges:
bors added a commit that referenced this pull request Feb 10, 2018
@bors
Auto merge of #48113 - kennytm:rollup, r=kennytm
45fba43 
Rollup of 20 pull requests

- Successful merges: #47790, #47835, #47854, #48015, #48047, #48051, #48058, #48059, #48064, #48078, #48080, #48086, #48098, #48101, #48107, #48100, #48085, #48120, #48124, #47547
- Failed merges:
@bors bors merged commit caa42e1 into rust-lang:master Feb 10, 2018
@bors
Copy link
Contributor

bors commented Feb 10, 2018

☔ The latest upstream changes (presumably #48113) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 10, 2018
@michaelwoerister
Copy link
Member

Thanks for taking over the review, @nikomatsakis. Back from PTO now.

@Mark-Simulacrum Mark-Simulacrum deleted the remove-data-structs branch June 8, 2019 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@Mark-Simulacrum @rust-highfive @eddyb @shepmaster @BatmanAoD @nikomatsakis @bors @michaelwoerister @alexcrichton @kennytm