Replace "lvalue" terminology with "place". #47837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
added
the
S-waiting-on-review
kennytm
reviewed
Jan 29, 2018
src/test/ui/issue-26093.stderr
Outdated
| @@ -4,7 +4,7 @@ error[E0070]: invalid left-hand side expression | |||
| 13 | $thing = 42; | |||
| | ^^^^^^^^^^^ left-hand of expression not valid | |||
| ... | |||
| 19 | not_an_lvalue!(99); | |||
| 19 | not_a_place!(99); | |||
| | ------------------- in this macro invocation | |||
There was a problem hiding this comment.
This line needs to be shortened.
[00:45:32] ---- [ui] ui/issue-26093.rs stdout ----
[00:45:32] diff of stderr:
[00:45:32]
[00:45:32] 5 | ^^^^^^^^^^^ left-hand of expression not valid
[00:45:32] 6 ...
[00:45:32] 7 19 | not_a_place!(99);
[00:45:32] + | ----------------- in this macro invocation
[00:45:32] - | ------------------- in this macro invocation
[00:45:32] 9
[00:45:32] 10 error: aborting due to previous error
[00:45:32] 11
There was a problem hiding this comment.
Oh right, I'm not running ui tests locally because they were broken at some point...
nikomatsakis
approved these changes
Jan 29, 2018
|
@bors r+ |
|
📌 Commit bba81c9 has been approved by |
kennytm
added
S-waiting-on-bors
|
@bors p=2 |
bors
added a commit
that referenced
this pull request
Jan 29, 2018
Replace "lvalue" terminology with "place". See #46425 for the previous PR (which only changed MIR-related code). r? @nikomatsakis
|
☀️ Test successful - status-appveyor, status-travis |
This was referenced Jan 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #46425 for the previous PR (which only changed MIR-related code).
r? @nikomatsakis