Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct unused field pattern suggestions #47922

Merged
merged 2 commits into from
Feb 7, 2018
Merged

correct unused field pattern suggestions #47922

merged 2 commits into from
Feb 7, 2018

Commits on Feb 1, 2018

  1. in which HirIdMap is introduced as an affordance for using HirIds more 

    The glossaries in the draft rustc-guide book and librustc/README.md
state that `NodeId` is being gradually phased out in favor of `HirId`;
as such, the present author claims that we ought to have a typedef for
efficient `HirId` maps and sets in the module for such, even if no use
for them has been made as yet (compatibility constraints preventing the
use of it in the author's present unit of work): it is important to
create the psychological "affordance" (in James J. Gibson's sense) that
`HirId`s are a thing that compiler developers can work with.
    @zackmdavis
    zackmdavis committed Feb 1, 2018
    Configuration menu
    Copy the full SHA
    8f9d915 View commit details
    Browse the repository at this point in the history

  2. concerning well-formed suggestions for unused shorthand field patterns 

    Previously, unused variables would get a note that the warning could be
silenced by prefixing the variable with an underscore, but that doesn't
work for field shorthand patterns, which the liveness analysis didn't
know about.

The "to avoid this warning" verbiage seemed unnecessary.

Resolves rust-lang#47390.
    @zackmdavis
    zackmdavis committed Feb 1, 2018
    1 Configuration menu
    Copy the full SHA
    e4b1a79 View commit details
    Browse the repository at this point in the history