Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RLS #48202

Merged
merged 2 commits into from
Feb 15, 2018
Merged

Update RLS #48202

merged 2 commits into from
Feb 15, 2018

Conversation

nrc
Copy link
Member

@nrc nrc commented Feb 14, 2018

Should fix the RLS test breakage.

r? @alexcrichton

@nrc nrc mentioned this pull request Feb 14, 2018
Merged
@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 14, 2018
@kennytm
Copy link
Member

kennytm commented Feb 14, 2018

@bors r+ p=3

@bors
Copy link
Contributor

bors commented Feb 14, 2018

📌 Commit fa94c5c has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 14, 2018
@bors
Copy link
Contributor

bors commented Feb 14, 2018

⌛ Testing commit fa94c5c with merge 234e7736ad7fc031454444a4c61441fed183b1a2...

@bors
Copy link
Contributor

bors commented Feb 14, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 14, 2018
@kennytm
Copy link
Member

kennytm commented Feb 14, 2018

distcheck failed, clippy_lints needs to be exempted (make sure clippy_lints is not used by libcore/liballoc/libstd, and then edit src/tools/tidy/src/deps.rs)

[00:36:43] invalid license MPL-2.0 in /checkout/obj/build/tmp/distcheck/src/vendor/clippy_lints/Cargo.toml
[00:36:43] some tidy checks failed

@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 14, 2018
@Mark-Simulacrum
Copy link
Member

@bors r=kennytm p=5

Excluded clippy_lints.

@bors
Copy link
Contributor

bors commented Feb 14, 2018

📌 Commit 45944f6 has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 14, 2018
@bors
Copy link
Contributor

bors commented Feb 14, 2018

⌛ Testing commit 45944f6 with merge 236d32fa637e20f0412865449cf3e565cfd3969c...

@bors
Copy link
Contributor

bors commented Feb 15, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 15, 2018
@Mark-Simulacrum
Copy link
Member

@bors retry - appveyor timed out

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 15, 2018
@bors
Copy link
Contributor

bors commented Feb 15, 2018

⌛ Testing commit 45944f6 with merge 90759be...

bors added a commit that referenced this pull request Feb 15, 2018
@bors
Auto merge of #48202 - nrc:update, r=kennytm
90759be 
Update RLS

Should fix the RLS test breakage.

r? @alexcrichton
@bors
Copy link
Contributor

bors commented Feb 15, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: kennytm
Pushing 90759be to master...

@bors bors merged commit 45944f6 into rust-lang:master Feb 15, 2018
@bors bors mentioned this pull request Feb 15, 2018
Closed
kennytm-githubbot added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Feb 15, 2018
@kennytm-githubbot
📣 Toolstate changed by rust-lang/rust#48202!
31e5eba 
Tested on commit rust-lang/rust@90759be.

🎉 rls on windows: test-fail → test-pass.
🎉 rls on linux: test-fail → test-pass.
@bors bors mentioned this pull request Feb 15, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nrc @kennytm @bors @Mark-Simulacrum @alexcrichton