Rollup of 23 pull requests #48203

kennytm · 2018-02-14T08:14:52Z

Successful merges: rustc: Add the ability to not run dsymutil #47784, Changed color of struct link from #ff794d to #2dbfb8 for Rust docs #47806, Work around LLVM OCAML binding installation failure #47846, Unimplement Send/Sync for ::env::{Args,ArgsOs,Vars,VarsOs} #48005, Show better warning for trying to cast non-u8 scalar to char #48033, Apply optimization from #44355 to retain #48065, Add Range[Inclusive]::is_empty #48087, Upgrade the Travis CI macOS images for testing from Xcode 8.3 to 9.2. #48114, Whitelist pclmulqdq x86 feature flag #48126, Correct a few stability attributes #48130, typo: correct endianess to endianness (this also changes function names!) #48133, Update ops range example to avoid confusion between indexes and values. #48151, Continue parsing function after finding ... arg #48154, Add std/core::iter::repeat_with #48156, Handle path prefix mapping in a more stable way when computing the crate hash #48162, rustc: Persist LLVM's Linker in Fat LTO #48163, Update compiletest's read2 function #48165, Remove allocation from width of character function. #48167, incr.comp.: Run cache directory garbage collection before loading dep-graph. #48181, Add note about Cargo cwd change to release notes #48186, Update compiler-builtins to latest master. #48195, Early exit for empty HashMap (issue #38880) #48035, Clarified why Sized bound not implicit on trait's implicit Self type. #48210
Failed merges:

During the RFC, it was discussed that figuring out whether a range is empty was subtle, and thus there should be a clear and obvious way to do it. It can't just be ExactSizeIterator::is_empty (also unstable) because not all ranges are ExactSize -- not even Range<i32> or RangeInclusive<usize>.

Relevant `stdsimd` [issue](rust-lang/stdarch#318).

…es!)

…h NAN

When encountering a variadic argument in a function definition that doesn't accept it, if immediately after there's a closing paren, continue parsing as normal. Otherwise keep current behavior of emitting error and stopping.

bors · 2018-02-15T04:37:16Z

💔 Test failed - status-appveyor

kennytm · 2018-02-15T06:09:46Z

@bors retry #46903

…_api_docs, r=QuietMisdreavus Clarified why `Sized` bound not implicit on trait's implicit `Self` type. This part of the documentation was a little confusing to me on first read. I've added a couple lines for further explanation. Hopefully this makes things a bit clearer for new readers.

kennytm · 2018-02-15T06:38:50Z

@bors r+

Added #48210

bors · 2018-02-15T06:38:50Z

📌 Commit 03b089d has been approved by kennytm

bors · 2018-02-15T07:31:37Z

⌛ Testing commit 03b089d with merge d33cb35a5082482863909e3cb8e25c903ca2200c...

bors · 2018-02-15T10:32:30Z

💔 Test failed - status-appveyor

kennytm · 2018-02-15T10:47:39Z

@bors retry #46903

bors · 2018-02-15T13:35:26Z

⌛ Testing commit 03b089d with merge 1670a53...

Rollup of 23 pull requests - Successful merges: #47784, #47806, #47846, #48005, #48033, #48065, #48087, #48114, #48126, #48130, #48133, #48151, #48154, #48156, #48162, #48163, #48165, #48167, #48181, #48186, #48195, #48035, #48210 - Failed merges:

bors · 2018-02-15T16:39:08Z

💔 Test failed - status-appveyor

kennytm · 2018-02-15T16:44:22Z

Manually merged, #46903 again, and previous tests https://ci.appveyor.com/project/rust-lang/rust/build/1.0.6355 already showed i686-pc-windows-gnu is good.

PramodBisht and others added 30 commits January 27, 2018 20:00

Changed color of struct link from #ff794d to #2dbfb8

7f6a53e

Work around LLVM OCAML binding installation failure

c04d86d

Changed of struct url to #ad448e in rust docs

434bfb1

Unimplement Send/Sync for ::env::{Args,ArgsOs,Vars,VarsOs}

b439632

38880 don't compute hash when searching an empty HashMap

9bc5986

This addresses issue rust-lang#38880

38880 use search_mut function rather than search_hashed

dcdd2c4

Apply optimization from rust-lang#44355 to retain

2a4c018

Swap ptr::read for ptr::drop_in_place

a67749a

Fix tidy

7fe182f

Use is_empty in range iteration exhaustion tests

b5cb393

range_is_empty tracking issue is rust-lang#48111

6f70a11

Show better warning for trying to cast non-u8 scalar to char

0cccd9a

Whitelist pclmul x86 feature flag

14f488e

Relevant `stdsimd` [issue](rust-lang/stdarch#318).

typo fix

877272b

Add comment about the problem, and use provided path if available

3c01dea

Correct a few stability attributes

45d5a42

added conversion from Rust feature to LLVM feature

8be3068

iterator instead loop

c97aa09

typo: correct endianess to endianness (this also changes function nam…

161e8ff

…es!)

fixed errors

7c6adb4

Add the emptiness condition to the docs; add a PartialOrd example wit…

22b0489

…h NAN

Upgrade the Travis CI macOS images for testing from Xcode 8.3 to 9.2.

bf69b0f

Dangling pointer fix

c2a31de

Update ops range example to avoid confusion between indexes and values.

bd426f1

Continue parsing function after finding ... arg

f7cabc6

When encountering a variadic argument in a function definition that doesn't accept it, if immediately after there's a closing paren, continue parsing as normal. Otherwise keep current behavior of emitting error and stopping.

add core::iter::repeat_with

0f789aa

core::iter::repeat_with: general fixes

c4099ca

core::iter::repeat_with: derive Copy, Clone, Debug

1af9ee1

core::iter::repeat_with: fix tests

f025eff

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 15, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 15, 2018

kennytm changed the title ~~Rollup of 22 pull requests~~ Rollup of 23 pull requests Feb 15, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 15, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 15, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 15, 2018

This was referenced Feb 15, 2018

Correct a few stability attributes #48130

Merged

typo: correct endianess to endianness (this also changes function names!) #48133

Merged

kennytm merged commit 03b089d into rust-lang:master Feb 15, 2018

bors mentioned this pull request Feb 15, 2018

Overhaul improper_ctypes output #48221

Merged

bors mentioned this pull request Feb 15, 2018

Add Iterator::flatten #48115

Merged

Centril added the rollup A PR which is a rollup label Oct 2, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 23 pull requests #48203

Rollup of 23 pull requests #48203

kennytm commented Feb 14, 2018 •

edited

Loading

bors commented Feb 15, 2018

kennytm commented Feb 15, 2018

kennytm commented Feb 15, 2018

bors commented Feb 15, 2018

bors commented Feb 15, 2018

bors commented Feb 15, 2018

kennytm commented Feb 15, 2018

bors commented Feb 15, 2018

bors commented Feb 15, 2018

kennytm commented Feb 15, 2018

Rollup of 23 pull requests #48203

Rollup of 23 pull requests #48203

Conversation

kennytm commented Feb 14, 2018 • edited Loading

bors commented Feb 15, 2018

kennytm commented Feb 15, 2018

kennytm commented Feb 15, 2018

bors commented Feb 15, 2018

bors commented Feb 15, 2018

bors commented Feb 15, 2018

kennytm commented Feb 15, 2018

bors commented Feb 15, 2018

bors commented Feb 15, 2018

kennytm commented Feb 15, 2018

kennytm commented Feb 14, 2018 •

edited

Loading