Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about ignored generic bounds in for #48326

Merged
merged 5 commits into from
Mar 9, 2018

Commits on Feb 27, 2018

  1. Configuration menu
    Copy the full SHA
    d1ed6cc View commit details
    Browse the repository at this point in the history
  2. add lint to detect ignored generic bounds; this subsumes the previous…

    … 'generic bounds in type aliases are ignored' warning
    RalfJung committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    86821f7 View commit details
    Browse the repository at this point in the history
  3. update compile-fail tests; remove now redundant issue-39122.rs

    It is subsumed by ui/param-bounds-ignored.rs.
    RalfJung committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    30b5be0 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2018

  1. make bounds on higher-kinded lifetimes a hard error in ast_validation

    Also move the check for not having type parameters into ast_validation.
    
    I was not sure what to do with compile-fail/issue-23046.rs: The issue looks like
    maybe the bounds actually played a role in triggering the ICE, but that seems
    unlikely given that the compiler seems to entirely ignore them.  However, I
    couldn't find a testcase without the bounds, so I figured the best I could do is
    to just remove the bounds and make sure at least that keeps working.
    RalfJung committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    49abd87 View commit details
    Browse the repository at this point in the history
  2. note a FIXME

    RalfJung committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    780b544 View commit details
    Browse the repository at this point in the history