Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize [T]::rotate_{left,right} #48450

Merged
merged 1 commit into from
Feb 28, 2018
Merged

Stabilize [T]::rotate_{left,right} #48450

merged 1 commit into from
Feb 28, 2018

Conversation

frewsxcv
Copy link
Member

@rust-highfive
Copy link
Collaborator

r? @withoutboats

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 23, 2018
@frewsxcv frewsxcv mentioned this pull request Feb 23, 2018
Closed
@frewsxcv
Copy link
Member Author

r? @rust-lang/libs

scottmcm
scottmcm reviewed Feb 23, 2018
View reviewed changes
src/liballoc/slice.rs Outdated
/// let mut a = ['a', 'b', 'c', 'd', 'e', 'f'];
/// a[1..5].rotate_left(1);
/// assert_eq!(a, ['a', 'c', 'd', 'e', 'b', 'f']);
/// ```
#[unstable(feature = "slice_rotate", issue = "41891")]
#[stable(feature = "slice_rotate", issue = "41891")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be since = "1.26.0", not issue?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep! good catch

@frewsxcv frewsxcv force-pushed the frewsxcxv-stabilize-slice-rotatee branch from da0fc93 to b1a6c8b Compare February 23, 2018 01:12
@frewsxcv frewsxcv added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Feb 23, 2018
@alexcrichton
Copy link
Member

Despite having only been added very recently (the rotate_{left,right} methods) we've had a method rotate for quite some time now. I think that the left/right-taking name seems much better and would be comfortable stabilizing this even though these specific apis only landed recently. Curious what others think tough!

@rfcbot fcp merge

@rfcbot
Copy link

rfcbot commented Feb 24, 2018 •
edited by sfackler
Loading

Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Feb 24, 2018
@sfackler
Copy link
Member

Yep, I'm happy with the left/right rename.

@rfcbot
Copy link

rfcbot commented Feb 26, 2018

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Feb 26, 2018
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Feb 26, 2018

📌 Commit b1a6c8b has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 26, 2018
@alexcrichton alexcrichton added the relnotes Marks issues that should be documented in the release notes of the next release. label Feb 26, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Feb 27, 2018
@kennytm
Rollup merge of rust-lang#48450 - frewsxcv:frewsxcxv-stabilize-slice-…
b106016 
…rotatee, r=alexcrichton

Stabilize [T]::rotate_{left,right}

rust-lang#41891
@kennytm kennytm mentioned this pull request Feb 27, 2018
Closed
@alexcrichton
Copy link
Member

@bors: rollup

@kennytm kennytm mentioned this pull request Feb 27, 2018
Closed
kennytm added a commit to kennytm/compiletest-rs that referenced this pull request Feb 27, 2018
@kennytm
Call rotate_left instead of rotate.
aede9af 
The `rotate` method has been deprecated in favor of `rotate_left` and `rotate_right` since rust-lang/rust#46777, and will be deleted in rust-lang/rust#48450.
@kennytm kennytm mentioned this pull request Feb 27, 2018
Merged
laumann pushed a commit to Manishearth/compiletest-rs that referenced this pull request Feb 27, 2018
@kennytm
Call rotate_left instead of rotate.
5c48e01 
The `rotate` method has been deprecated in favor of `rotate_left` and `rotate_right` since rust-lang/rust#46777, and will be deleted in rust-lang/rust#48450.
kennytm added a commit to kennytm/rust that referenced this pull request Feb 28, 2018
@kennytm
Rollup merge of rust-lang#48450 - frewsxcv:frewsxcxv-stabilize-slice-…
ef44e63 
…rotatee, r=alexcrichton

Stabilize [T]::rotate_{left,right}

rust-lang#41891
@kennytm kennytm mentioned this pull request Feb 28, 2018
Merged
bors added a commit that referenced this pull request Feb 28, 2018
@bors
Auto merge of #48608 - kennytm:rollup, r=kennytm
0ff9872 
Rollup of 15 pull requests

- Successful merges: #48266, #48321, #48365, #48381, #48450, #48473, #48479, #48484, #48488, #48497, #48541, #48548, #48558, #48560, #48565
- Failed merges:
@bors bors merged commit b1a6c8b into rust-lang:master Feb 28, 2018
@frewsxcv frewsxcv deleted the frewsxcxv-stabilize-slice-rotatee branch February 28, 2018 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottmcm scottmcm scottmcm approved these changes

Assignees
No one assigned
Labels
final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@frewsxcv @rust-highfive @alexcrichton @rfcbot @sfackler @bors @scottmcm @withoutboats