Remove --host and --target arguments to configure in Dockerfiles #48600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
@bors: r+ Nice! |
|
📌 Commit 0b06357 has been approved by |
bors
added
S-waiting-on-bors
|
@bors p=2 prioritizing risky-to-rollup PRs so they get tested first |
|
⌛ Testing commit 0b06357e6f8bd3a351124be5a1b41a64804da8bb with merge b3311b263d1534ce1b840c08817ae479ab03494a... |
|
💔 Test failed - status-travis |
bors
added
S-waiting-on-review
kennytm
reviewed
Mar 2, 2018
| @@ -82,13 +82,11 @@ RUN sh /scripts/sccache.sh | |||
| ENV HOSTS=i686-unknown-linux-gnu | |||
|
|
|||
| ENV RUST_CONFIGURE_ARGS \ | |||
| --host=$HOSTS \ | |||
| --enable-extended \ | |||
| --enable-sanitizers \ | |||
| --enable-profiler \ | |||
| --enable-emscripten \ | |||
kennytm
added
S-waiting-on-author
These arguments are passed to the relevant x.py invocation in all cases anyway. As such, there is no need to separately configure them. x.py will ignore the configuration when they are passed on the command line anyway.
Mark-Simulacrum
force-pushed
the
rustbuild-updates-2
branch
from
0b06357 to
ab7ce1c
Compare
|
@bors r=alexcrichton |
|
📌 Commit ab7ce1c has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Mar 4, 2018
…chton Remove --host and --target arguments to configure in Dockerfiles These arguments are passed to the relevant x.py invocation in all cases anyway. As such, there is no need to separately configure them. x.py will ignore the configuration when they are passed on the command line anyway. r? @alexcrichton
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These arguments are passed to the relevant x.py invocation in all cases
anyway. As such, there is no need to separately configure them. x.py
will ignore the configuration when they are passed on the command line
anyway.
r? @alexcrichton