travis: Upgrade dist builders for OSX #48891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit upgrades the dist builders for OSX to Travis's new `xcode9.3-moar` image which has 3 cores available to it instead of 2. This should help us provide speedier builds on OSX and hit timeouts less in theory! Note that historically the dist builders for OSX have been a different version than the ones that are running tests. I had forgotten why this was the case and digging around brought up 3076155 where apparently Xcode 8 wasn't able to compile LLVM with `MACOSX_DEPLOYMENT_TARGET=10.7` which we desired. On a whim I gave this PR a spin and it [looks like][green] this has since been fixed (maybe in LLVM?). In any case those green builds should hopefully mean that we can safely upgrade and get faster infrastructure to boot. This commit also includes an upgrade of OpenSSL. This is not done for security reasons but rather build system reasons. Originally builds with the new image [did not succeed][red] due to weird build failures in OpenSSL, but upgrading seems to have made the spurious errors go away to here's to also hoping that's fixed! [green]: https://travis-ci.org/rust-lang/rust/builds/351353412 [red]: https://travis-ci.org/rust-lang/rust/builds/350969248
|
@bors r+ p=20 I've verified the compiled rustc has the correct minimum macOS version. The priority is set to very high as an attempt to close #48866. Currently #48866 has 50% chance to kill any invocation of stage2's rustc (meaning: always fail), hopefully upgrading the Xcode version will automatically fix the bug. |
|
📌 Commit d65dfd1 has been approved by |
bors
added
the
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Mar 9, 2018
travis: Upgrade dist builders for OSX This commit upgrades the dist builders for OSX to Travis's new `xcode9.3-moar` image which has 3 cores available to it instead of 2. This should help us provide speedier builds on OSX and hit timeouts less in theory! Note that historically the dist builders for OSX have been a different version than the ones that are running tests. I had forgotten why this was the case and digging around brought up 3076155 where apparently Xcode 8 wasn't able to compile LLVM with `MACOSX_DEPLOYMENT_TARGET=10.7` which we desired. On a whim I gave this PR a spin and it [looks like][green] this has since been fixed (maybe in LLVM?). In any case those green builds should hopefully mean that we can safely upgrade and get faster infrastructure to boot. This commit also includes an upgrade of OpenSSL. This is not done for security reasons but rather build system reasons. Originally builds with the new image [did not succeed][red] due to weird build failures in OpenSSL, but upgrading seems to have made the spurious errors go away to here's to also hoping that's fixed! [green]: https://travis-ci.org/rust-lang/rust/builds/351353412 [red]: https://travis-ci.org/rust-lang/rust/builds/350969248
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit upgrades the dist builders for OSX to Travis's new
xcode9.3-moarimage which has 3 cores available to it instead of 2. This should help us
provide speedier builds on OSX and hit timeouts less in theory!
Note that historically the dist builders for OSX have been a different version
than the ones that are running tests. I had forgotten why this was the case and
digging around brought up 3076155 where apparently Xcode 8 wasn't able to
compile LLVM with
MACOSX_DEPLOYMENT_TARGET=10.7which we desired. On a whim Igave this PR a spin and it looks like this has since been fixed (maybe
in LLVM?). In any case those green builds should hopefully mean that we can
safely upgrade and get faster infrastructure to boot.
This commit also includes an upgrade of OpenSSL. This is not done for security
reasons but rather build system reasons. Originally builds with the new image
did not succeed due to weird build failures in OpenSSL, but upgrading
seems to have made the spurious errors go away to here's to also hoping that's
fixed!