Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing inline annotations to Cell #48905

Closed
wants to merge 1 commit into from
Closed

Commits on Mar 10, 2018

  1. Add missing inline annotations to Cell

    Were seeing some odd performance problems when using incremental compilation where `Rc` pointers were actually slower than `Arc` pointers (the problem goes away when using non-incremental compilation). I haven't been able to build rustc locally to verify that this fixes it but these missing inline annotations seem to be the only thing that could affect performance (to this extent).
    
    ```
    test vector_push_back        ... bench:  11,668,015 ns/iter (+/- 772,861)
    test vector_push_back_mut    ... bench:   1,423,771 ns/iter (+/- 22,011)
    test vector_push_back_mut_rc ... bench:   1,181,765 ns/iter (+/- 123,724)
    test vector_push_back_rc     ... bench:  17,141,746 ns/iter (+/- 203,048)
    ```
    (Source and non incremental benchmarks orium/rpds#7 (comment))
    Marwes authored Mar 10, 2018
    Configuration menu
    Copy the full SHA
    58fced4 View commit details
    Browse the repository at this point in the history