Try to reduce amount of time on the asmjs builder #49095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since all tests are compiled with LTO effectively in Emscripten this commit disables optimizations to hopefully squeeze some more time out of the CI builders. Closes rust-lang#48826
Many tests run on the asmjs builder like compile-fail, ui, parse-fail, etc, aren't actually specific to asm.js. Instead of running redundant test suites this commit changes things up to only run tests that actually emit JS we then pass to node.
|
r? @kennytm |
kennytm
reviewed
Mar 17, 2018
| ENV SCRIPT python2.7 ../x.py test --target $TARGETS | ||
| ENV SCRIPT python2.7 ../x.py test --target $TARGETS \ | ||
| src/test/run-pass \ | ||
| src/test/run-fail \ |
There was a problem hiding this comment.
I think we should still enable run-pass-fulldeps, run-fail-fulldeps and run-make.
There was a problem hiding this comment.
Oh currently I don't believe we run any of those tests, right?
There was a problem hiding this comment.
Oh let me check...
Indeed they aren't run. In the previous build, the following tests are executed:
- ui
- run-pass
- compile-fail
- parse-fail
- run-fail
- run-pass-valgrind
- mir-opt
- codegen
- codegen-units
- incremental
- debuginfo-gdb
- (and the libraries)
|
@bors r+ |
|
📌 Commit 60eb308 has been approved by |
bors
added
the
S-waiting-on-bors
|
@bors p=5 |
bors
added a commit
that referenced
this pull request
Mar 19, 2018
Try to reduce amount of time on the asmjs builder This PR has two commits for two separate strategies: * First it disables optimizations for all tests, hopefully saving time by not optimizing the test code. This caused a number of run-pass tests to fail which are switched to being ignored here. * Next it disables a number of test suites which aren't asm.js specific and already run elsewhere cc #48826
|
☀️ Test successful - status-appveyor, status-travis |
This was referenced Mar 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has two commits for two separate strategies:
cc #48826