Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce scope of unsafe block in sun_path_offset #49315

Merged
merged 1 commit into from
Mar 25, 2018
Merged

Reduce scope of unsafe block in sun_path_offset #49315

merged 1 commit into from
Mar 25, 2018

Conversation

TheDan64
Copy link
Contributor

I reduced the scope of the unsafe block to the uninitialized call which is the only actual unsafe bit.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 23, 2018
@joshtriplett
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 25, 2018

📌 Commit fdde09c has been approved by joshtriplett

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 25, 2018
@bors
Copy link
Contributor

bors commented Mar 25, 2018

⌛ Testing commit fdde09c with merge 482a913...

bors added a commit that referenced this pull request Mar 25, 2018
@bors
Auto merge of #49315 - TheDan64:smaller_unsafe_block, r=joshtriplett
482a913 
Reduce scope of unsafe block in sun_path_offset

I reduced the scope of the unsafe block to the `uninitialized` call which is the only actual unsafe bit.
@bors
Copy link
Contributor

bors commented Mar 25, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: joshtriplett
Pushing 482a913 to master...

@bors bors merged commit fdde09c into rust-lang:master Mar 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joshtriplett joshtriplett

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TheDan64 @rust-highfive @joshtriplett @bors