Allow niche-filling dataful variants to be represented as a ScalarPair #49383
Conversation
src/librustc/ty/layout.rs
Outdated
| if offset.bytes() == 0 { | ||
| // We need to use scalar_unit to reset the | ||
| // valid range to the maximal one for that | ||
| // primitive. |
There was a problem hiding this comment.
Can you put it outside and say that it's because only the niche is guaranteed to always be initialized, not the other primitive?
|
@bors r+ |
|
📌 Commit 9e5b398 has been approved by |
bors
added
the
S-waiting-on-bors
|
@bors r+ |
|
📌 Commit bda718f has been approved by |
|
@Mark-Simulacrum Can we get this on perf.rust-lang.org?
|
|
It'll be collected automatically once it's merged; if we want to get data prior to merging I can run it if we build try artifacts. |
|
Asking just because @eddyb mentioned it would be a good thing on #rustc, but you decide I don’t know if it’s worth it if it lands soon.
|
|
@bors try I'll get the artifacts for now anyway, though we won't need them if/when this goes through bors. |
Allow niche-filling dataful variants to be represented as a ScalarPair r? @eddyb
|
☀️ Test successful - status-travis |
|
⌛ Testing commit bda718f with merge 980153bd338af3e09716a39859ffe6012710cc8e... |
|
💔 Test failed - status-travis |
bors
added
S-waiting-on-review
|
This failure is #43283, can we get a p=1 retry? |
bors
added
S-waiting-on-bors
Allow niche-filling dataful variants to be represented as a ScalarPair r? @eddyb
|
☀️ Test successful - status-appveyor, status-travis |
r? @eddyb