Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize get_type_id #49613

Closed
wants to merge 1 commit into from
Closed

Stabilize get_type_id #49613

wants to merge 1 commit into from

Conversation

tmccombs
Copy link
Contributor

@tmccombs tmccombs commented Apr 3, 2018

Fixes #27745

@pietroalbini pietroalbini added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. relnotes Marks issues that should be documented in the release notes of the next release. labels Apr 3, 2018
@est31
Copy link
Member

est31 commented Apr 3, 2018

Only read half of the thread but shouldn't the function be renamed to type_id?

@aidanhs
Copy link
Member

aidanhs commented Apr 3, 2018

There didn't seem to be consensus in the tracking issue for stabilisation during the fcp and there was a request for more information on whether there's any important use-case waiting on it landing in stable. @tmccombs, perhaps it would be better to comment in the tracking issue with this if you have feedback? Otherwise, nothing has changed since the last fcp.

Regardless, I'll leave to the libs team.
r? @alexcrichton

@rust-highfive rust-highfive assigned alexcrichton and unassigned aidanhs Apr 3, 2018
@alexcrichton
Copy link
Member

Thanks for the PR @tmccombs! Unfortunately I think there may be a bug in fcp where I registered a blocking concern to block stabilizing this method but it didn't halt the FCP process.

As @aidanhs mentioned though if you've got thoughts they'd be most welcome on the issue!

@tmccombs
Copy link
Contributor Author

tmccombs commented Apr 3, 2018

Oh, I missed that when I was reading through the tracking issue.

@tmccombs tmccombs closed this Apr 3, 2018
@tmccombs tmccombs mentioned this pull request Jun 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tmccombs @est31 @aidanhs @alexcrichton @pietroalbini