Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove underscore_lifetimes and match_default_bindings from active feature list #49647

Merged
merged 1 commit into from
Apr 16, 2018

Conversation

kennytm
Copy link
Member

@kennytm kennytm commented Apr 4, 2018

These are already stabilized in 1.26.

@kennytm kennytm added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 4, 2018
@kennytm
Copy link
Member Author

kennytm commented Apr 4, 2018

Nominating for beta. These entries are also repeated in beta.

$ rg 'underscore_lifetimes|match_default_bindings' -- src/libsyntax/feature_gate.rs
386:    (active, underscore_lifetimes, "1.22.0", Some(44524), None),
389:    (active, match_default_bindings, "1.22.0", Some(42640), None),
567:    (accepted, match_default_bindings, "1.26.0", Some(42640), None),
569:    (accepted, underscore_lifetimes, "1.26.0", Some(44524), None),

@pietroalbini pietroalbini added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 4, 2018
@pietroalbini
Copy link
Member

Ping from triage @aturon! This PR needs your review.

@pietroalbini pietroalbini added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 16, 2018
@pietroalbini
Copy link
Member

Ping from triage! Can @aturon or someone else from @rust-lang/compiler review this?

@aturon
Copy link
Member

aturon commented Apr 16, 2018

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 16, 2018

📌 Commit 3a55f2b has been approved by aturon

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2018
…e feature list

These are already stabilized in 1.26.
@kennytm kennytm force-pushed the duplicated-features branch from 3a55f2b to 6c3e1d7 Compare April 16, 2018 19:28
@kennytm
Copy link
Member Author

kennytm commented Apr 16, 2018

@bors r=aturon

@bors
Copy link
Contributor

bors commented Apr 16, 2018

📌 Commit 6c3e1d7 has been approved by aturon

kennytm added a commit to kennytm/rust that referenced this pull request Apr 16, 2018
Remove `underscore_lifetimes` and `match_default_bindings` from active feature list

These are already stabilized in 1.26.
bors added a commit that referenced this pull request Apr 16, 2018
Rollup of 8 pull requests

Successful merges:

 - #49555 (Inline most of the code paths for conversions with boxed slices)
 - #49606 (Prevent broken pipes causing ICEs)
 - #49646 (Use box syntax instead of Box::new in Mutex::remutex on Windows)
 - #49647 (Remove `underscore_lifetimes` and `match_default_bindings` from active feature list)
 - #49931 (Fix incorrect span in `&mut` suggestion)
 - #49959 (rustbuild: allow building tools with debuginfo)
 - #49965 (Remove warning about f64->f32 cast being potential UB)
 - #49994 (Remove unnecessary indentation in rustdoc book codeblock.)

Failed merges:
@bors bors merged commit 6c3e1d7 into rust-lang:master Apr 16, 2018
@alexcrichton alexcrichton added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Apr 20, 2018
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 20, 2018
bors added a commit that referenced this pull request Apr 21, 2018
[beta] Processing merged backports

This is a backport of the following PRs:

* #49386
* #49465
* #49647
* #49692
* #49695
* #49714
* #49730
* #49830
* #49981
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants