Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't inject clippy into rls on stable/beta #49876

Merged
merged 1 commit into from
Apr 14, 2018
Merged

Don't inject clippy into rls on stable/beta #49876

merged 1 commit into from
Apr 14, 2018

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Apr 11, 2018

r? @nrc

as discussed at the all-hands

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 11, 2018
@kennytm kennytm added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 11, 2018
@nrc
Copy link
Member

nrc commented Apr 12, 2018

@bors: r+

We'd normally discuss the beta request at a meeting, but this seems obviously a good thing to uplift, so beta approving too.

@bors
Copy link
Contributor

bors commented Apr 12, 2018

📌 Commit 34956c8 has been approved by nrc

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 12, 2018
@nrc nrc added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Apr 12, 2018
@oli-obk
Copy link
Contributor Author

oli-obk commented Apr 12, 2018

Is the rls-preview component available on beta/stable? If not, there's no need to backport

@nrc
Copy link
Member

nrc commented Apr 13, 2018

Is the rls-preview component available on beta/stable? If not, there's no need to backport

It is

kennytm added a commit to kennytm/rust that referenced this pull request Apr 13, 2018
@kennytm
Rollup merge of rust-lang#49876 - oli-obk:no_secret_clippy_on_stable_…
9dbfcb5 
…☹, r=nrc

Don't inject clippy into rls on stable/beta

r? @nrc

as discussed at the all-hands
@kennytm kennytm mentioned this pull request Apr 13, 2018
Closed
@kennytm kennytm mentioned this pull request Apr 13, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Apr 14, 2018
@kennytm
Rollup merge of rust-lang#49876 - oli-obk:no_secret_clippy_on_stable_…
c22b4db 
…☹, r=nrc

Don't inject clippy into rls on stable/beta

as discussed at the all-hands
bors added a commit that referenced this pull request Apr 14, 2018
@bors
Auto merge of #49939 - kennytm:rollup, r=kennytm
21dae95 
Rollup of 14 pull requests

Successful merges: #49908, #49876, #49916, #49951, #49465, #49922, #49866, #49915, #49886, #49913, #49852, #49958, #49871, #49864

Failed merges:
@bors bors merged commit 34956c8 into rust-lang:master Apr 14, 2018
@oli-obk oli-obk deleted the no_secret_clippy_on_stable_☹ branch April 17, 2018 13:34
@oli-obk oli-obk mentioned this pull request Apr 17, 2018
Closed
@oli-obk oli-obk removed beta-accepted Accepted for backporting to the compiler in the beta channel. beta-nominated Nominated for backporting to the compiler in the beta channel. labels Apr 17, 2018
@oli-obk oli-obk mentioned this pull request Apr 17, 2018
Merged
@kennytm kennytm added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Apr 17, 2018
bors added a commit that referenced this pull request Apr 19, 2018
@bors
Auto merge of #50027 - oli-obk:const_signed_pat_beta, r=kennytm
8423230 
[beta] backport various PRs

original PRs:

* #49949 (not yet merged at the time of writing)
* #49947 (long running const eval error -> warning)
* #49833 (static recursion)
* #49876 (no clippy in stable rls)
* #49904 (Work around LLVM debuginfo problem in librustc_driver. )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nrc nrc

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oli-obk @nrc @bors @kennytm @rust-highfive