Fix unsoundness bug in functions input references #49885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
spastorino
force-pushed
the
fn_ref_unsound
branch
2 times, most recently
from
1753809 to
aaaafa9
Compare
Check that function input references are well formed
spastorino
force-pushed
the
fn_ref_unsound
branch
2 times, most recently
from
8230c10 to
55fb12c
Compare
|
@bors r+ |
|
📌 Commit 55fb12c has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Apr 15, 2018
Fix unsoundness bug in functions input references Fixes #48803 r? @nikomatsakis
|
☀️ Test successful - status-appveyor, status-travis |
tamird
reviewed
Apr 18, 2018
| debug!( | ||
| "prove_predicates(predicates={:?}, location={:?})", | ||
| predicates, location | ||
| predicates_iter.by_ref().collect::<Vec<_>>(), |
There was a problem hiding this comment.
won't this exhaust the iterator, so that this code no longer generates any obligations below when debug output is enabled?
There was a problem hiding this comment.
Ooops, you're right. Going to fix this :).
There was a problem hiding this comment.
Fixed, PR sent #50076
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48803
r? @nikomatsakis