Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn on all erroneous constants #50110

Merged
merged 1 commit into from
Apr 25, 2018
Merged

Warn on all erroneous constants #50110

merged 1 commit into from
Apr 25, 2018

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Apr 20, 2018

fixes #49791
fixes #47054

@Zoxc this PR triggers the nondeterministic errors of #49950 (comment) really often (at least on stage1).

@rust-highfive

This comment has been minimized.

Sign in to view
@oli-obk oli-obk force-pushed the warn_all_the_constants branch from 56d87c8 to 55325ee Compare April 20, 2018 12:45
@rust-highfive

This comment has been minimized.

Sign in to view
@oli-obk
Copy link
Contributor Author

oli-obk commented Apr 20, 2018

nevermind, the "nondeterminism" was due to #50113, which has a fix incoming, and it's only happening locally, travis is never affected

@oli-obk oli-obk force-pushed the warn_all_the_constants branch from 55325ee to 7bf50e6 Compare April 20, 2018 14:35
@oli-obk oli-obk mentioned this pull request Apr 20, 2018
Closed
@pietroalbini
Copy link
Member

Highfive failed to assign a reviewer, picking someone randomly -- @estebank

@pietroalbini pietroalbini added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 20, 2018
@bors

This comment has been minimized.

Sign in to view
@oli-obk oli-obk force-pushed the warn_all_the_constants branch from 7bf50e6 to 9e0b85c Compare April 24, 2018 10:09
@rust-highfive

This comment has been minimized.

Sign in to view
@oli-obk oli-obk force-pushed the warn_all_the_constants branch from 9e0b85c to cd6c186 Compare April 24, 2018 11:12
@oli-obk oli-obk mentioned this pull request Apr 24, 2018
Closed
@eddyb
Copy link
Member

eddyb commented Apr 24, 2018

LGTM, I think.

r? @nikomatsakis

@estebank
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Apr 24, 2018

📌 Commit cd6c186 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2018
@bors
Copy link
Contributor

bors commented Apr 25, 2018

⌛ Testing commit cd6c186 with merge 92dae5dd77ef606cbb72975212052165882f4db1...

@bors
Copy link
Contributor

bors commented Apr 25, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 25, 2018
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
[00:01:28]  Downloading toml v0.4.6
[00:01:28] error: unable to get packages from source
[00:01:28] 
[00:01:28] Caused by:
[00:01:28]   failed to get 200 response from `https://crates.io/api/v1/crates/toml/0.4.6/download`, got 404
[00:01:28] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:28] Build completed unsuccessfully in 0:00:38
[00:01:28] make: *** [prepare] Error 1
[00:01:28] Makefile:81: recipe for target 'prepare' failed
[00:01:29]  Downloading libc v0.2.40
[00:01:29] error: unable to get packages from source
[00:01:29] 
[00:01:29] Caused by:
[00:01:29] Caused by:
[00:01:29]   failed to get 200 response from `https://crates.io/api/v1/crates/libc/0.2.40/download`, got 404
[00:01:29] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:29] Build completed unsuccessfully in 0:00:00
[00:01:29] make: *** [prepare] Error 1
[00:01:29] Makefile:81: recipe for target 'prepare' failed
[00:01:29]  Downloading lazy_static v0.2.11
[00:01:30] error: unable to get packages from source
[00:01:30] 
[00:01:30] Caused by:
[00:01:30] Caused by:
[00:01:30]   failed to get 200 response from `https://crates.io/api/v1/crates/lazy_static/0.2.11/download`, got 404
[00:01:30] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:30] Build completed unsuccessfully in 0:00:00
[00:01:30] Makefile:81: recipe for target 'prepare' failed
[00:01:30] make: *** [prepare] Error 1
[00:01:30]  Downloading serde v1.0.40
[00:01:30] error: unable to get packages from source
[00:01:30] 
[00:01:30] Caused by:
[00:01:30] Caused by:
[00:01:30]   failed to get 200 response from `https://crates.io/api/v1/crates/serde/1.0.40/download`, got 404
[00:01:30] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:30] Build completed unsuccessfully in 0:00:00
[00:01:30] make: *** [prepare] Error 1
[00:01:30] Makefile:81: recipe for target 'prepare' failed
[00:01:31]  Downloading cc v1.0.10
[00:01:31] error: unable to get packages from source
[00:01:31] 
[00:01:31] Caused by:
[00:01:31] Caused by:
[00:01:31]   failed to get 200 response from `https://crates.io/api/v1/crates/cc/1.0.10/download`, got 404
[00:01:31] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:31] Build completed unsuccessfully in 0:00:00
[00:01:31] Makefile:81: recipe for target 'prepare' failed
[00:01:31] make: *** [prepare] Error 1
[00:01:31] The command has failed after 5 attempts.

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 1.
travis_time:start:00e0ba8c
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@nagbot-rs
Copy link

nagbot-rs commented Apr 25, 2018 via email

@bors
Copy link
Contributor

bors commented Apr 25, 2018

@nagbot-rs: 🔑 Insufficient privileges: not in try users

@aturon
Copy link
Member

aturon commented Apr 25, 2018

@bors: retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 25, 2018
@bors
Copy link
Contributor

bors commented Apr 25, 2018

⌛ Testing commit cd6c186 with merge 5ec6637...

bors added a commit that referenced this pull request Apr 25, 2018
@bors
Auto merge of #50110 - oli-obk:warn_all_the_constants, r=estebank
5ec6637 
Warn on all erroneous constants

fixes #49791
fixes #47054

@Zoxc this PR triggers the nondeterministic errors of #49950 (comment) really often (at least on stage1).
@bors
Copy link
Contributor

bors commented Apr 25, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: estebank
Pushing 5ec6637 to master...

@bors bors merged commit cd6c186 into rust-lang:master Apr 25, 2018
@pietroalbini pietroalbini added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 25, 2018
@pietroalbini
Copy link
Member

Nominating for backport into beta, since this fixes a regression.

@nikomatsakis nikomatsakis added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Apr 25, 2018
@pietroalbini pietroalbini mentioned this pull request Apr 25, 2018
Merged
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 25, 2018
bors added a commit that referenced this pull request Apr 25, 2018
@bors
Auto merge of #50224 - pietroalbini:beta-backports, r=alexcrichton
1861fb5 
[beta] Process backports

* #49779: Don't report compile-time errors for promoteds
* #50110: Warn on all erroneous constants
@oli-obk oli-obk deleted the warn_all_the_constants branch June 15, 2020 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warn or Error on errors in constants? An unusable constant should at least warn
10 participants
@oli-obk @rust-highfive @pietroalbini @bors @eddyb @estebank @nagbot-rs @aturon @alexcrichton @nikomatsakis