Check Sized in wfcheck for externed DSTs, closes #36122 #50126
Conversation
|
Thanks for the PR! Highfive failed to assign a reviewer, picking one randomly: @petrochenkov |
pietroalbini
added
the
S-waiting-on-review
| @@ -301,16 +313,34 @@ fn check_item_fn<'a, 'tcx>(tcx: TyCtxt<'a, 'tcx, 'tcx>, item: &hir::Item) { | |||
| }) | |||
| } | |||
|
|
|||
| pub fn check_item_sized<'a, 'tcx>(tcx: TyCtxt<'a, 'tcx, 'tcx>, id: NodeId) { | |||
There was a problem hiding this comment.
Apparently this should be done in librustc_typeck/check/mod.rs using require_type_is_sized and not in wfcheck.
So this leaves wfcheck with check_item_type only.
There was a problem hiding this comment.
Should it be done in CheckItemTypesVisitor.visit_item in librustc_typeck/check/mod.rs for example?
There was a problem hiding this comment.
Probably in fn check_item_type
petrochenkov
added
S-waiting-on-author
|
Ping from triage, @krk ! Will you have time to address the review feedback in the near future? |
|
Yes, I will have time possibly this week. Thanks for the ping! |
|
Ping from triage, @krk ! Could you give us a short update? (It's perfectly fine if you are busy right now / need more time; just checking in). |
|
Hi @krk, we're closing this PR due to inactivity to keep our queue clean. Please re-open this or another PR when you have the time to work on it again. Thanks for your work! |
Require type is sized in wfcheck.check_item_type for externed DSTs, c… …loses rust-lang#36122 Continuing rust-lang#50126.
@ #36122