Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hash EntryKind::AssociatedConst const data #50207

Merged
merged 1 commit into from
Apr 26, 2018
Merged

Hash EntryKind::AssociatedConst const data #50207

merged 1 commit into from
Apr 26, 2018

Conversation

wesleywiser
Copy link
Member

Related to #49991
r? @michaelwoerister
cc @eddyb

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 25, 2018
@eddyb
Copy link
Member

eddyb commented Apr 25, 2018

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 25, 2018

📌 Commit d81d081 has been approved by eddyb

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 25, 2018
@michaelwoerister
Copy link
Member

It won't hurt but this isn't actually needed since the HashStable implementation for Lazy<T> is a no-op. Metadata hashing is dead code nowadays anyway, afaik.

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Apr 26, 2018
@GuillaumeGomez
Rollup merge of rust-lang#50207 - wesleywiser:hash_const_data, r=eddyb
0d758ec 
Hash EntryKind::AssociatedConst const data

Related to rust-lang#49991
r? @michaelwoerister
cc @eddyb
@GuillaumeGomez GuillaumeGomez mentioned this pull request Apr 26, 2018
Merged
bors added a commit that referenced this pull request Apr 26, 2018
@bors
Auto merge of #50245 - GuillaumeGomez:rollup, r=GuillaumeGomez
88cd367 
Rollup of 4 pull requests

Successful merges:

 - #50177 (mark std::str::replace(,n) as #[must_use])
 - #50207 (Hash EntryKind::AssociatedConst const data)
 - #50214 (Js improvements)
 - #50219 (Added missing `.` in docs.)

Failed merges:

 - #50229 (Add setting to go to item if there is only one result)
@bors bors merged commit d81d081 into rust-lang:master Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaelwoerister michaelwoerister

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wesleywiser @eddyb @bors @michaelwoerister @rust-highfive