Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run more passes on constant mir #50282

Merged
merged 3 commits into from
May 2, 2018

Conversation

fitzgen
Copy link
Member

@fitzgen fitzgen commented Apr 27, 2018

Not very familiar with this code, but everything seems to be working!

r? @eddyb

fitzgen added 3 commits April 27, 2018 06:49
Now that miri is merged, this seems to Just Work!
Seems to Just Work since miri merged.
Appears to work now that miri has merged.
@fitzgen fitzgen force-pushed the run-more-passes-on-constant-mir branch from d933701 to 1129a71 Compare April 27, 2018 14:03
@eddyb
Copy link
Member

eddyb commented Apr 27, 2018

LGTM. r? @nikomatsakis

@pietroalbini pietroalbini added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 28, 2018
@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Apr 30, 2018

📌 Commit 1129a71 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 30, 2018
@bors
Copy link
Contributor

bors commented May 1, 2018

⌛ Testing commit 1129a71 with merge 9bc67ad...

bors added a commit that referenced this pull request May 1, 2018
…omatsakis

Run more passes on constant mir

Not very familiar with this code, but everything seems to be working!

r? @eddyb
@bors
Copy link
Contributor

bors commented May 1, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 1, 2018
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-distcheck of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:43:34] [RUSTC-TIMING] rustc_const_math test:false 7.285
[00:43:55] [RUSTC-TIMING] proc_macro test:false 27.921
[00:43:55]    Compiling syntax_ext v0.0.0 (file:///checkout/obj/build/tmp/distcheck/src/libsyntax_ext)
[00:44:39] [RUSTC-TIMING] syntax_ext test:false 43.823
No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

1 similar comment
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-distcheck of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:43:34] [RUSTC-TIMING] rustc_const_math test:false 7.285
[00:43:55] [RUSTC-TIMING] proc_macro test:false 27.921
[00:43:55]    Compiling syntax_ext v0.0.0 (file:///checkout/obj/build/tmp/distcheck/src/libsyntax_ext)
[00:44:39] [RUSTC-TIMING] syntax_ext test:false 43.823
No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@kennytm
Copy link
Member

kennytm commented May 1, 2018

@bors retry

30 minutes no output

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 1, 2018
@bors
Copy link
Contributor

bors commented May 2, 2018

⌛ Testing commit 1129a71 with merge c1168be...

bors added a commit that referenced this pull request May 2, 2018
…omatsakis

Run more passes on constant mir

Not very familiar with this code, but everything seems to be working!

r? @eddyb
@bors
Copy link
Contributor

bors commented May 2, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing c1168be to master...

@bors bors merged commit 1129a71 into rust-lang:master May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants