Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rls with compiling clippy #50503

Merged
merged 2 commits into from
May 8, 2018
Merged

Update rls with compiling clippy #50503

merged 2 commits into from
May 8, 2018

Conversation

alexheretic
Copy link
Member

Updates rls to use a working clippy version. This pr can be closed if the latest clippy release is broken again.

@alexheretic
Update rls 1263f1f
e4a0514 
Fix rls-clippy feature compile
@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

warning Warning warning

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 7, 2018
@alexheretic
Copy link
Member Author

r? @nrc

@rust-highfive rust-highfive assigned nrc and unassigned nikomatsakis May 7, 2018
@alexheretic alexheretic mentioned this pull request May 7, 2018
Merged
@oli-obk
Copy link
Contributor

oli-obk commented May 7, 2018

Can you also update the clippy submodule?

@alexheretic
Copy link
Member Author

Can do!

@oli-obk
Copy link
Contributor

oli-obk commented May 7, 2018

Superb!

@bors r+ p=1

@bors
Copy link
Contributor

bors commented May 7, 2018

📌 Commit 640e937 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 7, 2018
@bors
Copy link
Contributor

bors commented May 7, 2018

⌛ Testing commit 640e937 with merge bd9bfc8bb7af59b13cecf9fec72a87ecca676554...

@bors
Copy link
Contributor

bors commented May 7, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 7, 2018
@oli-obk
Copy link
Contributor

oli-obk commented May 8, 2018 •
edited
Loading

Failure during stage 1 bootstrap:

RUSTC-TIMING] syntax test:false 42.900
error: Could not compile `syntax`.
Caused by:
  process didn't exit successfully: `C:\projects\rust\build\bootstrap/debug/rustc --crate-name syntax libsyntax\lib.rs --color always --error-format json --crate-type dylib --emit=dep-info,link -C prefer-dynamic -C opt-level=3 -C metadata=b3cbb9541fe504c3 -C extra-filename=-b3cbb9541fe504c3 --out-dir C:\projects\rust\build\x86_64-pc-windows-msvc\stage1-rustc\x86_64-pc-windows-msvc\release\deps --target x86_64-pc-windows-msvc -L dependency=C:\projects\rust\build\x86_64-pc-windows-msvc\stage1-rustc\x86_64-pc-windows-msvc\release\deps -L dependency=C:\projects\rust\build\x86_64-pc-windows-msvc\stage1-rustc\release\deps --extern rustc_target=C:\projects\rust\build\x86_64-pc-windows-msvc\stage1-rustc\x86_64-pc-windows-msvc\release\deps\rustc_target-ec8b8fc40e1e234f.dll --extern rustc_data_structures=C:\projects\rust\build\x86_64-pc-windows-msvc\stage1-rustc\x86_64-pc-windows-msvc\release\deps\rustc_data_structures-bef295d814b4002d.dll --extern serialize=C:\projects\rust\build\x86_64-pc-windows-msvc\stage1-rustc\x86_64-pc-windows-msvc\release\deps\serialize-aadbf4fd58f68d72.dll --extern serialize=C:\projects\rust\build\x86_64-pc-windows-msvc\stage1-rustc\x86_64-pc-windows-msvc\release\deps\libserialize-aadbf4fd58f68d72.rlib --extern bitflags=C:\projects\rust\build\x86_64-pc-windows-msvc\stage1-rustc\x86_64-pc-windows-msvc\release\deps\libbitflags-5dd360579c965793.rlib --extern scoped_tls=C:\projects\rust\build\x86_64-pc-windows-msvc\stage1-rustc\x86_64-pc-windows-msvc\release\deps\libscoped_tls-7e567af1d5e963ff.rlib --extern rustc_errors=C:\projects\rust\build\x86_64-pc-windows-msvc\stage1-rustc\x86_64-pc-windows-msvc\release\deps\rustc_errors-79f354c4761a2801.dll --extern syntax_pos=C:\projects\rust\build\x86_64-pc-windows-msvc\stage1-rustc\x86_64-pc-windows-msvc\release\deps\syntax_pos-97f4632685d938eb.dll --extern log=C:\projects\rust\build\x86_64-pc-windows-msvc\stage1-rustc\x86_64-pc-windows-msvc\release\deps\liblog-a32ff88dfd92b898.rlib` (exit code: 3221225477)
command did not execute successfully: "C:\\projects\\rust\\build\\x86_64-pc-windows-msvc\\stage0/bin\\cargo.exe" "build" "--target" "x86_64-pc-windows-msvc" "-j" "4" "--release" "--locked" "--color" "always" "--features" "" "--manifest-path" "C:\\projects\\rust\\src/rustc/Cargo.toml" "--message-format" "json"
expected success, got: exit code: 101
thread 'main' panicked at 'cargo must succeed', bootstrap\compile.rs:1091:9
note: Run with `RUST_BACKTRACE=1` for a backtrace.
failed to run: C:\projects\rust\build\bootstrap\debug\bootstrap dist

cc @kennytm

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 8, 2018
@bors
Copy link
Contributor

bors commented May 8, 2018

⌛ Testing commit 640e937 with merge de8e2066ad8a4a64f8f3cd685f1657994b00756a...

@bors
Copy link
Contributor

bors commented May 8, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 8, 2018
@rust-highfive
Copy link
Collaborator

The job arm-android of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
[01:37:40] test net::tcp::tests::debug ... ok
[01:37:40] test net::tcp::tests::double_bind ... ok
[01:37:40] test net::tcp::tests::fast_rebind ... ok
[01:37:41] test net::tcp::tests::listen_localhost ... ok
[01:37:42] died due to signal 11
[01:37:42] 
[01:37:42] 
[01:37:42] 
[01:37:42] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "arm-linux-androideabi" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind jemalloc backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "-p" "std" "--"
[01:37:42] 
[01:37:42] 
[01:37:42] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --target arm-linux-androideabi
[01:37:42] Build completed unsuccessfully in 1:24:41

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive
Copy link
Collaborator

The job arm-android of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
[01:37:40] test net::tcp::tests::debug ... ok
[01:37:40] test net::tcp::tests::double_bind ... ok
[01:37:40] test net::tcp::tests::fast_rebind ... ok
[01:37:41] test net::tcp::tests::listen_localhost ... ok
[01:37:42] died due to signal 11
[01:37:42] 
[01:37:42] 
[01:37:42] 
[01:37:42] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "arm-linux-androideabi" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind jemalloc backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "-p" "std" "--"
[01:37:42] 
[01:37:42] 
[01:37:42] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --target arm-linux-androideabi
[01:37:42] Build completed unsuccessfully in 1:24:41

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@oli-obk
Copy link
Contributor

oli-obk commented May 8, 2018

A lot of other builders succeeded, spurious again?

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 8, 2018
@kennytm kennytm mentioned this pull request May 8, 2018
Merged
@bors
Copy link
Contributor

bors commented May 8, 2018

⌛ Testing commit 640e937 with merge 697a989...

bors added a commit that referenced this pull request May 8, 2018
@bors
Auto merge of #50503 - alexheretic:master, r=oli-obk
697a989 
Update rls with compiling clippy

Updates rls to use a working clippy version. This pr can be closed if the latest clippy release is broken again.
@bors
Copy link
Contributor

bors commented May 8, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: oli-obk
Pushing 697a989 to master...

@bors bors merged commit 640e937 into rust-lang:master May 8, 2018
@kennytm-githubbot
Copy link

📣 Toolstate changed by #50503!

Tested on commit 697a989.
Direct link to PR: #50503

🎉 clippy-driver on windows: build-fail → test-pass.
🎉 clippy-driver on linux: build-fail → test-pass.

kennytm-githubbot added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request May 8, 2018
@kennytm-githubbot
📣 Toolstate changed by rust-lang/rust#50503!
f3574ad 
Tested on commit rust-lang/rust@697a989.
Direct link to PR: <rust-lang/rust#50503>

🎉 clippy-driver on windows: build-fail → test-pass.
🎉 clippy-driver on linux: build-fail → test-pass.
@kennytm kennytm mentioned this pull request May 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nrc nrc

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@alexheretic @rust-highfive @oli-obk @bors @kennytm-githubbot @nikomatsakis @nrc