Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update openbsd targets #50678

Merged
merged 2 commits into from
May 13, 2018
Merged

Update openbsd targets #50678

merged 2 commits into from
May 13, 2018

Conversation

semarie
Copy link
Contributor

@semarie semarie commented May 12, 2018

  • add a new target aarch64-unknown-openbsd
  • update i686-unknown-openbsd to use lld with clang, in order to correctly link binaries with i128

@rust-highfive
Copy link
Collaborator

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 12, 2018
@semarie
Copy link
Contributor Author

semarie commented May 12, 2018

r? @alexcrichton

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:05:25]    Compiling ena v0.9.2
[00:05:25]    Compiling jobserver v0.1.11
[00:05:27]    Compiling parking_lot_core v0.2.14
[00:05:27]    Compiling tempdir v0.3.7
[00:05:29] error[E0432]: unresolved import `LinkerFlavor`
[00:05:29]   --> librustc_target/spec/aarch64_unknown_openbsd.rs:11:5
[00:05:29] 11 | use LinkerFlavor;
[00:05:29] 11 | use LinkerFlavor;
[00:05:29]    |     ^^^^^^^^^^^^ no `LinkerFlavor` in the root
[00:05:29] 
[00:05:29] error[E0432]: unresolved import `target`
[00:05:29]   --> librustc_target/spec/aarch64_unknown_openbsd.rs:12:5
[00:05:29]    |
[00:05:29] 12 | use target::{Target, TargetResult};
[00:05:29]    |     ^^^^^^ Maybe a missing `extern crate target;`?
[00:05:29]    Compiling rustc_apfloat v0.0.0 (file:///checkout/src/librustc_apfloat)
[00:05:30]    Compiling rls-span v0.4.0
[00:05:31] error: aborting due to 2 previous errors
[00:05:31] 
[00:05:31] 
[00:05:31] For more information about this error, try `rustc --explain E0432`.
[00:05:31] error: Could not compile `rustc_target`.
[00:05:31] 
[00:05:31] Caused by:
[00:05:31]   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc --crate-name rustc_target librustc_target/lib.rs --color always --error-format json --crate-type dylib --emit=dep-info,link -C prefer-dynamic -C opt-level=3 --cfg feature="jemalloc" -C metadata=aed9d8ab86b35123 -C extra-filename=-aed9d8ab86b35123 --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/release/deps --extern serialize=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libserialize-946eff7380f27f57.so --extern serialize=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libserialize-946eff7380f27f57.rlib --extern bitflags=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libbitflags-401bddd0d1809e53.rlib --extern rustc_cratesio_shim=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_cratesio_shim-a7895f6d3b02c33b.so --extern log=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/liblog-4f0866e958f59455.rlib` (exit code: 101)
Sat, 12 May 2018 08:06:31 GMT
travis_time:end:07ffbbee:start=1526112391244265537,finish=1526112391306706563,duration=62441026

The command "date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

semarie added 2 commits May 12, 2018 10:27
standard binutils on openbsd is too old to do proper job with i128
code.
@semarie semarie force-pushed the openbsd-targets branch from 31a7ac2 to f430d7c Compare May 12, 2018 08:28
@sanxiyn
Copy link
Member

sanxiyn commented May 12, 2018

@bors r+

@bors
Copy link
Contributor

bors commented May 12, 2018

📌 Commit f430d7c has been approved by sanxiyn

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 12, 2018
kennytm added a commit to kennytm/rust that referenced this pull request May 13, 2018
Update openbsd targets

- add a new target `aarch64-unknown-openbsd`
- update `i686-unknown-openbsd` to use lld with clang, in order to correctly link binaries with `i128`
bors added a commit that referenced this pull request May 13, 2018
Rollup of 8 pull requests

Successful merges:

 - #50624 (fs::write: Add example writing a &str)
 - #50634 (Do not silently truncate offsets for `read_at`/`write_at` on emscripten)
 - #50644 (AppVeyor: Read back trace from crash dump on failure.)
 - #50661 (Ignore non .rs files for tidy libcoretest)
 - #50663 (rustc: Allow an edition's feature on that edition)
 - #50667 (rustc: Only suggest deleting `extern crate` if it works)
 - #50670 (rustc: Include semicolon when removing `extern crate`)
 - #50678 (Update openbsd targets)

Failed merges:
@bors bors merged commit f430d7c into rust-lang:master May 13, 2018
@semarie semarie deleted the openbsd-targets branch May 13, 2018 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants