Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] Process backports #50708

Merged
merged 2 commits into from
May 13, 2018
Merged

[beta] Process backports #50708

merged 2 commits into from
May 13, 2018

Conversation

pietroalbini
Copy link
Member

@pietroalbini pietroalbini commented May 13, 2018 •
edited
Loading

r? @alexcrichton

eddyb and others added 2 commits May 13, 2018 16:20
@eddyb @pietroalbini
rustc: leave space for fields of uninhabited types to allow partial i…
046bb83 
…nitialization.
@dlrobertson @pietroalbini
typeck: Fix ICE with struct update syntax
7041b65 
If check_expr_struct_fields fails, do not continue to record update.
If we continue to record update, the struct may cause us to ICE later
on indexing a field that may or may not exist.
@rust-highfive
Copy link
Collaborator

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 13, 2018
@alexcrichton
Copy link
Member

@bors: r+

Thanks @pietroalbini!

@bors
Copy link
Contributor

bors commented May 13, 2018

📌 Commit 7041b65 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 13, 2018
@pietroalbini
Copy link
Member Author

@bors p=1 (beta backport)

@bors
Copy link
Contributor

bors commented May 13, 2018

⌛ Testing commit 7041b65 with merge 5d261a0...

bors added a commit that referenced this pull request May 13, 2018
@bors
Auto merge of #50708 - pietroalbini:beta-backports, r=alexcrichton
5d261a0 
[beta] Process backports

* #50622: rustc: leave space for fields of uninhabited types to allow partial initialization.
* #50643: typeck: Fix ICE with struct update syntax

r? @alexcrichton
@bors
Copy link
Contributor

bors commented May 13, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 5d261a0 to beta...

@bors bors merged commit 7041b65 into rust-lang:beta May 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pietroalbini @rust-highfive @alexcrichton @bors @eddyb @dlrobertson