Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

experimental: Share generic code for optimized builds. #50861

Closed
wants to merge 1 commit into from
Closed

experimental: Share generic code for optimized builds. #50861

wants to merge 1 commit into from

Conversation

michaelwoerister
Copy link
Member

This is not meant to be merged. I just want to see how sharing monomorphizations affects optimized builds.

@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 18, 2018
@michaelwoerister
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented May 18, 2018

⌛ Trying commit 43101b6 with merge b60bd5703773a04cd853519fdc2465dc9d45603d...

@bors
Copy link
Contributor

bors commented May 18, 2018

☀️ Test successful - status-travis
State: approved= try=True

@michaelwoerister
Copy link
Member Author

@Mark-Simulacrum, would you mind starting a perf-run for this?

@michaelwoerister michaelwoerister added S-waiting-on-perf Status: Waiting on a perf run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 18, 2018
@Mark-Simulacrum
Copy link
Member

Perf queued for b60bd5703773a04cd853519fdc2465dc9d45603d.

@ishitatsuyuki
Copy link
Contributor

https://perf.rust-lang.org/compare.html?start=fd18d2537ddcffb24b3739393b085ed28dfc340e&end=b60bd5703773a04cd853519fdc2465dc9d45603d&stat=instructions%3Au

@pietroalbini pietroalbini added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels May 21, 2018
@ishitatsuyuki
Copy link
Contributor

Do we have whole crate graph LTO by default? From my understanding this should be paired with that, and should not be enabled on dylibs right?

@michaelwoerister
Copy link
Member Author

Do we have whole crate graph LTO by default?

No, that would probably take too long.

From my understanding this should be paired with that, and should not be enabled on dylibs right?

It's probably best to wait for MIR-only RLIBs (which are blocked on query parallelization). Those should be even better at sharing code without the runtime performance implications.

@michaelwoerister michaelwoerister mentioned this pull request Apr 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@michaelwoerister @rust-highfive @bors @Mark-Simulacrum @ishitatsuyuki @aturon @pietroalbini