-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter global bounds from ParamEnv again. #50876
Conversation
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
ae5c1eb
to
aa56353
Compare
Will this be merged? |
@bors r+ p=2 -- fixing regression, important |
📌 Commit aa56353 has been approved by |
⌛ Testing commit aa56353 with merge 240d2edc701cde5d70aa5cd92ea4eb0986ce003f... |
💔 Test failed - status-travis |
This comment has been minimized.
This comment has been minimized.
@bors retry Text file busy |
…atsakis Filter global bounds from ParamEnv again. This PR adds back the filtering of global bounds from ParamEnv as a temporary solution for #50825. <details> Long term, the fix seems like it should be changing the priority in `candidate_should_be_dropped_in_favor_of` so that (global) where clauses aren't considered as highly. https://github.com/rust-lang/rust/blob/a722296b6ec17fecd3f16a7d3f9232b83e5de800/src/librustc/traits/select.rs#L2017-L2022 </details> r? @nikomatsakis
☀️ Test successful - status-appveyor, status-travis |
This PR adds back the filtering of global bounds from ParamEnv as a temporary solution for #50825.
Long term, the fix seems like it should be changing the priority in
candidate_should_be_dropped_in_favor_of
so that (global) where clauses aren't considered as highly.rust/src/librustc/traits/select.rs
Lines 2017 to 2022 in a722296
r? @nikomatsakis