Remove the unstable Float trait #50933

SimonSapin · 2018-05-21T09:51:17Z

Following up to #49896 and #50629. Fixes #32110.

rust-highfive · 2018-05-21T09:51:20Z

(rust_highfive has picked a reviewer for you, use r? to override)

rust-highfive · 2018-05-21T11:20:50Z

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[01:27:55] 
[01:27:55] failures:
[01:27:55] 
[01:27:55] ---- /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0689 (line 10992) stdout ----
[01:27:55] error[E0599]: no method named `recip` found for type `{float}` in the current scope
[01:27:55]  --> /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md:10993:5
[01:27:55]   |
[01:27:55] 3 | 2.0.recip();
[01:27:55] 
[01:27:55] 
[01:27:55] thread '/checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0689 (line 10992)' panicked at 'Some expected error codes were not found: ["E0689"]', librustdoc/test.rs:330:13
[01:27:55] 
[01:27:55] ---- /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0689 (line 10998) stdout ----
[01:27:55] ---- /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0689 (line 10998) stdout ----
[01:27:55] error[E0599]: no method named `recip` found for type `{float}` in the current scope
[01:27:55]  --> /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md:11000:3
[01:27:55]   |
[01:27:55] 4 | x.recip();  // same error as above
[01:27:55]   |   ^^^^^
[01:27:55] 
[01:27:55] thread '/checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0689 (line 10998)' panicked at 'Some expected error codes were not found: ["E0689"]', librustdoc/test.rs:330:13
[01:27:55] 
[01:27:55] failures:
[01:27:55]     /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0689 (line 10992)
[01:27:55]     /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0689 (line 10998)
---
[01:27:55] 
[01:27:55] 
[01:27:55] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:27:55] Build completed unsuccessfully in 0:42:25
[01:27:55] Makefile:58: recipe for target 'check' failed
[01:27:55] make: *** [check] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:12ceaada
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2018-05-21T16:03:43Z

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[01:53:37] 
[01:53:37] failures:
[01:53:37] 
[01:53:37] ---- /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0689 (line 10992) stdout ----
[01:53:37] thread '/checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0689 (line 10992)' panicked at 'test compiled while it wasn't supposed to', librustdoc/test.rs:315:17
[01:53:37] 
[01:53:37] ---- /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0689 (line 10998) stdout ----
[01:53:37] ---- /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0689 (line 10998) stdout ----
[01:53:37] thread '/checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0689 (line 10998)' panicked at 'test compiled while it wasn't supposed to', librustdoc/test.rs:315:17
[01:53:37] 
[01:53:37] failures:
[01:53:37]     /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0689 (line 10992)
[01:53:37]     /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0689 (line 10998)
---
[01:53:37] 
[01:53:37] 
[01:53:37] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:53:37] Build completed unsuccessfully in 0:56:07
[01:53:37] make: *** [check] Error 1
[01:53:37] Makefile:58: recipe for target 'check' failed

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:06a72080
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

fbstj · 2018-05-22T15:19:35Z

src/libcore/num/dec2flt/rawfp.rs

    + Debug
    + LowerExp
    + Mul<Output=Self>
    + Div<Output=Self>
    + Neg<Output=Self>
-where
-    Self: Float<Bits = <Self as RawFloat>::RawBits>
 {
    const INFINITY: Self;
    const NAN: Self;
    const ZERO: Self;

    /// Same as `Float::Bits` with extra traits.


since Float is being removed, might be worth updating this doc to be more descriptive

Good point, fixed.

fbstj · 2018-05-22T15:20:35Z

src/libcore/num/dec2flt/rawfp.rs

@@ -56,22 +56,28 @@ impl Unpacked {
 /// Should **never ever** be implemented for other types or be used outside the dec2flt module.
 /// Inherits from `Float` because there is some overlap, but all the reused methods are trivial.


same as before "inherits from Float" is no longer true

I’ve now removed this sentence.

Following up to rust-lang#49896 and rust-lang#50629. Fixes rust-lang#32110. E0689 is weird.

withoutboats · 2018-05-23T01:58:25Z

I have no context

@bors r? @alexcrichton

alexcrichton · 2018-05-23T02:24:41Z

@bors: r+

bors · 2018-05-23T02:24:43Z

📌 Commit b825477 has been approved by alexcrichton

bors · 2018-05-23T22:50:20Z

⌛ Testing commit b825477 with merge 1977849...

Remove the unstable Float trait Following up to #49896 and #50629. Fixes #32110.

bors · 2018-05-24T01:25:32Z

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 1977849 to master...

rust-highfive assigned withoutboats May 21, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 21, 2018

SimonSapin force-pushed the anchorage branch from 5796b20 to 1612d0c Compare May 21, 2018 14:07

SimonSapin force-pushed the anchorage branch 2 times, most recently from 5e991f8 to 2208cf1 Compare May 21, 2018 19:20

fbstj reviewed May 22, 2018

View reviewed changes

Remove the unstable Float trait

b825477

Following up to rust-lang#49896 and rust-lang#50629. Fixes rust-lang#32110. E0689 is weird.

SimonSapin force-pushed the anchorage branch from 2208cf1 to b825477 Compare May 22, 2018 17:19

rust-highfive assigned alexcrichton and unassigned withoutboats May 23, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 23, 2018

bors added a commit that referenced this pull request May 23, 2018

Auto merge of #50933 - SimonSapin:anchorage, r=alexcrichton

1977849

Remove the unstable Float trait Following up to #49896 and #50629. Fixes #32110.

bors merged commit b825477 into rust-lang:master May 24, 2018

SimonSapin deleted the anchorage branch May 29, 2018 19:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove the unstable Float trait #50933

Remove the unstable Float trait #50933

SimonSapin commented May 21, 2018

rust-highfive commented May 21, 2018

rust-highfive commented May 21, 2018

rust-highfive commented May 21, 2018

fbstj May 22, 2018

SimonSapin May 22, 2018

fbstj May 22, 2018

SimonSapin May 22, 2018

withoutboats commented May 23, 2018

alexcrichton commented May 23, 2018

bors commented May 23, 2018

bors commented May 23, 2018

bors commented May 24, 2018

		@@ -56,22 +56,28 @@ impl Unpacked {
		/// Should never ever be implemented for other types or be used outside the dec2flt module.
		/// Inherits from `Float` because there is some overlap, but all the reused methods are trivial.

Remove the unstable Float trait #50933

Remove the unstable Float trait #50933

Conversation

SimonSapin commented May 21, 2018

rust-highfive commented May 21, 2018

rust-highfive commented May 21, 2018

rust-highfive commented May 21, 2018

fbstj May 22, 2018

Choose a reason for hiding this comment

SimonSapin May 22, 2018

Choose a reason for hiding this comment

fbstj May 22, 2018

Choose a reason for hiding this comment

SimonSapin May 22, 2018

Choose a reason for hiding this comment

withoutboats commented May 23, 2018

alexcrichton commented May 23, 2018

bors commented May 23, 2018

bors commented May 23, 2018

bors commented May 24, 2018