Select Polonius algorithm via POLONIUS_ALGORITHM environment variable
#51246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
vakaras
force-pushed
the
select_polonius_algo_via_env_var
branch
2 times, most recently
from
02e2169 to
8d61e69
Compare
vakaras
changed the title
POLONIUS_ALGORITHM environment variablePOLONIUS_ALGORITHM environment variable
nikomatsakis
requested changes
Jun 1, 2018
| let algorithm = env::var("POLONIUS_ALGORITHM") | ||
| .unwrap_or(String::from("DatafrogOpt")); | ||
| let algorithm = Algorithm::from_str(&algorithm).unwrap(); | ||
| info!("Using Polonius algorithm: {:?}", algorithm); |
There was a problem hiding this comment.
I don't know why this would be info! level in particular — I would say make it debug!, and probably:
debug!("compute_regions: using polonius algorithm {:?}", algorithm);
nikomatsakis
added
S-waiting-on-author
vakaras
force-pushed
the
select_polonius_algo_via_env_var
branch
from
8d61e69 to
265b04d
Compare
nikomatsakis
approved these changes
Jun 4, 2018
|
@bors r+ |
|
📌 Commit 265b04d has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 265b04d with merge 6ac784c21adad47ecf3e1e49a14859c8617ad4d5... |
|
💔 Test failed - status-appveyor |
bors
added
S-waiting-on-review
|
🤔 |
|
This seems to be spurious? @bors retry |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 265b04d with merge 005322cc0a24306657e0e23af6d0591c2cb8f260... |
|
💔 Test failed - status-travis |
bors
added
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
1 similar comment
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Was this some network issue? |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jun 5, 2018
…komatsakis Select Polonius algorithm via `POLONIUS_ALGORITHM` environment variable This pull request allows selecting the Polonius algorithm being used by providing an environment variable `POLONIUS_ALGORITHM`. Example usage: ``` POLONIUS_ALGORITHM=compare RUST_LOG=rustc_mir::borrow_check::nll=trace ./x.py test --stage 1 --compare-mode polonius -- src/test/ui/nll/issue-47680.rs ... stderr: ------------------------------------------ INFO 2018-05-31T17:35:31Z: rustc_mir::borrow_check::nll: Using Polonius algorithm: Compare INFO 2018-05-31T17:35:31Z: rustc_mir::borrow_check::nll: Using Polonius algorithm: Compare ------------------------------------------ ... ``` r? @nikomatsakis
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request allows selecting the Polonius algorithm being used by providing an environment variable
POLONIUS_ALGORITHM.Example usage:
r? @nikomatsakis