-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tries to address the recent network issues #51420
Conversation
It has no effect on deployment error and may cause further network issues.
ec7d602
to
c023bb1
Compare
Tries to workaround travis-ci/travis-ci#9696.
c023bb1
to
32e8bda
Compare
This looks good to me, r=me when ready. |
Do we know which DNS servers Travis was using before? |
@pietroalbini 169.254.169.254, which according to https://stackoverflow.com/a/32723910 is the same as the Google Public DNS for external domains, but I'm not sure if Travis has done some additional configuration in between. |
Hmm, if that points to the same resolver it shouldn't make a difference using 8.8.8.8, but whatever, this change won't hurt, let's try it. |
Yeah that's also why I've included 1.1.1.1 as backup. Though if 8.8.8.8 really responded "cannot resolve" then the OS won't consult the remaining items. |
@bors r=Mark-Simulacrum |
📌 Commit 32e8bda has been approved by |
🌲 The tree is currently closed for pull requests below priority 10, this pull request will be tested once the tree is reopened |
…-Simulacrum Tries to address the recent network issues 1. Set the DNS server to 8.8.8.8/8.8.4.4/1.1.1.1/1.0.0.1 to workaround the daily "Cannot resolve host" error these two weeks. 2. Remove the unnecessary command `gem update --system` (originally added as experiment of the "Could not find a valid gem" error, which turns out to be useless).
Rollup of 9 pull requests Successful merges: - #51186 (Remove two redundant .nll.stderr files) - #51283 (Deny #[cfg] and #[cfg_attr] on generic parameters.) - #51368 (Fix the use of closures within #[panic_implementation]) - #51380 (Remove dependency on fmt_macros from typeck) - #51389 (rustdoc: Fix missing stability and src links for inlined external macros) - #51399 (NLL performance boost) - #51407 (Update RLS and Rustfmt) - #51417 (Revert #49719) - #51420 (Tries to address the recent network issues) Failed merges:
Remove Travis shutdown debug scripts, and remove CI-specific DNS settings Since the cause of the host shutdown (travis-ci/travis-ci#4924) is found, we could revert the shutdown debug attempts to shorten the logs. Additionally, we're pretty sure a custom DNS (added in will not help travis-ci/travis-ci#9696, so reverting that part of rust-lang#51420 to reduce CI-specific settings.
gem update --system
(originally added as experiment of the "Could not find a valid gem" error, which turns out to be useless).