-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise an error if gcov profiling and incremental compilation are both enabled #51645
Raise an error if gcov profiling and incremental compilation are both enabled #51645
Conversation
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
CC @kennytm |
I'm not sure this is the correct approach. Shouldn't LLVM re-generate all the necessary files? |
I'm not exactly sure how incremental compilation works, so I don't know. This is just aknowledging the current situation, where you can't use them both, I think it's better than failing without an explanation. The other option would be to allow it but print a warning, like you're doing for some other features (count_llvm_insns, time_llvm_passes). In those cases the feature is half broken though, here it's completely broken. |
IIRC, @michaelwoerister is unavailable for reviews until early July, could someone else from @rust-lang/compiler review this? |
While I do agree with @eddyb I also think until we have an idea how to fix it properly we should do this. Maybe we just open an issue to fix it and merge this PR? |
📌 Commit 28670b6 has been approved by |
…michaelwoerister Raise an error if gcov profiling and incremental compilation are both enabled Fixes #50203.
☀️ Test successful - status-appveyor, status-travis |
Thanks a lot! |
Fixes #50203.