-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RLS and Rustfmt #51677
Update RLS and Rustfmt #51677
Conversation
@bors r+ p=84 |
📌 Commit 04df56ca26995b2748a4247512c9994808ad7ad3 has been approved by |
⌛ Testing commit 04df56ca26995b2748a4247512c9994808ad7ad3 with merge 565cc733c08ef2dbc1006a469238ec63ed3cf9ea... |
💔 Test failed - status-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@@ -348,7 +348,7 @@ dependencies = [ | |||
|
|||
[[package]] | |||
name = "clippy_lints" | |||
version = "0.0.205" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we keep clippy_lints
at version 0.0.206 or below? Otherwise we'll be blocked by the 1.29.0 compiler bump (similar to #51122).
If we must upgrade clippy_lints I'd prefer we close this PR and update everything in the 1.29.0 version bump.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neither 0.0.205 or 0.0.207 clippy version is buildable with master so rls
could temporary disable dependency. I think it would be simplest solution for now.
Another solution would be disabling edition=2018
in clippy
and fixing incompatible code, then releasing new version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that we'd need to make and keep a branch around forever, let's just wait till the 1.29 bump (it's only a few days, right?)
@bors r- Requeued again, sorry the infra is very broken this week. |
☔ The latest upstream changes (presumably #51739) made this pull request unmergeable. Please resolve the merge conflicts. |
#51717 has been merged. |
r? @kennytm |
☔ The latest upstream changes (presumably #51732) made this pull request unmergeable. Please resolve the merge conflicts. |
@bors: r=kennytm |
📌 Commit 3df836162afdf0a2a5b3a9c53ba5869d1aebad64 has been approved by |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
⌛ Testing commit 3df836162afdf0a2a5b3a9c53ba5869d1aebad64 with merge 0825b84ad4f72bcc0d60e9e5cb3aac41b250d477... |
💔 Test failed - status-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
1 similar comment
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
That ordslice fix disappeared?
|
@bors: r=kennytm Can someone sacrifice a goat or something to get this to land? |
📌 Commit 7717705 has been approved by |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Update RLS and Rustfmt r? @Mark-Simulacrum
☀️ Test successful - status-appveyor, status-travis |
Tested on commit rust-lang/rust@ded86cc. Direct link to PR: <rust-lang/rust#51677> 🎉 rls on windows: build-fail → test-pass. 🎉 rls on linux: build-fail → test-pass. 🎉 rustfmt on windows: build-fail → test-pass. 🎉 rustfmt on linux: build-fail → test-pass.
r? @Mark-Simulacrum